Adium

Opened 15 years ago

Closed 14 years ago

#1347 closed defect (fixed)

Status Time Problem

Reported by: freakman Owned by: nobody
Milestone: Adium X 1.1 Component: Adium UI
Version: Severity: minor
Keywords: Cc:
Patch Status:

Description (last modified by Trevin Ward)

When someone is idle for more than 24 hours in the contact list it doesn't convert their idle time to days. IE: instead of 26h, 1d or 1d 2h.

Attachments (1)

1347_idletimeformat.diff (8.4 KB) - added by Pheredhel 14 years ago.
an attempt to fix this ticket

Download all attachments as: .zip

Change History (15)

comment:1 Changed 15 years ago by Zachary West

Component: Adium CoreAdium UI
Milestone: Adium X 0.90Adium X 0.85
Type: enhancementdefect

Milestone fix, not an enhancement,

comment:2 Changed 15 years ago by David Smith

Milestone: Adium X 0.85
priority: normallowest
Severity: normaltrivial

I believe this is a gaim issue.

comment:3 Changed 15 years ago by David Smith

Resolution: wontfix
Status: newclosed

WONTFIXing, as it's a gaim issue. Possibly reopen w/regard to joscar if it's still an issue.

comment:4 Changed 15 years ago by Chris Forsythe

Milestone: Adium X 0.90

We can't calculate that (24 hours) = (1 day) in adium? Setting milestone for now so this isn't lost

comment:5 Changed 15 years ago by David Smith

My brief look through the code indicated that gaim takes an idle time as a number of seconds, and we're using the idle string we get from that. I suppose it would be possible to stick something in between that and displaying it in the contact list.

comment:6 Changed 15 years ago by Evan Schoenberg

What does it even mean that "the number of hours isn't converted into days"? It doesn't show up properly remotely? Locally? If locally, where? If remotely, how does it show up?

comment:7 Changed 15 years ago by David Smith

Resolution: wontfix
Status: closedreopened

This looks like it should be fixable, actually.

comment:8 Changed 15 years ago by David Smith

Milestone: Adium X 1.0Adium X 1.1

Milestone -> 1.1, I've got better things to work on for the moment

comment:9 Changed 15 years ago by Trevin Ward

Description: modified (diff)
field_haspatch: 0

Clarified theClarified the description, I was looking at making a ticket but I'll just clarify this one! Hooray for no dupes!

comment:10 Changed 14 years ago by Chris Forsythe

Milestone: Adium X 1.1Adium X 1.3

Changed 14 years ago by Pheredhel

Attachment: 1347_idletimeformat.diff added

an attempt to fix this ticket

comment:11 Changed 14 years ago by David Smith

Comments:

Should probably use NSTimeInterval (which is a typedef'd float) rather than doubles.

There seems to be a good bit of code duplication there; it may be possible to have one or more methods call through each other to avoid that, or factor common code out into a private method.

Fixing the method name shouldn't be terribly difficult; just search for it in the project and update anywhere it's called.

Typo in the docs headers; Intervall -> Interval

Other than that, looks great :)

comment:12 Changed 14 years ago by David Smith

Milestone: Adium X 1.3Adium X 1.1
Resolution: fixed
Status: reopenedclosed

Fixed in [18029]

comment:13 Changed 14 years ago by Chris Forsythe

Component: Adium UIJabber
Milestone: Adium X 1.1Sometime after 1.0
Resolution: fixed
Status: closedreopened

We are no longer utilizing Smack, so we will need to rethink how to do this with libgaim.

comment:14 Changed 14 years ago by Chris Forsythe

Component: JabberAdium UI
Milestone: Sometime after 1.0Adium X 1.1
Resolution: fixed
Status: reopenedclosed

Oops!

Note: See TracTickets for help on using tickets.