Adium

Opened 10 years ago

Closed 8 years ago

Last modified 7 years ago

#13278 closed patch (fixed)

add support for alerts generated only while the account is away

Reported by: jcs Owned by:
Milestone: Adium 1.5 Component: Events
Version: 1.4hg Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description

Summary

create CONTENT_MESSAGE_RECEIVED_AWAY, hook it up so it will trigger when messages are received on an account that is away (actually just any status not AIAvailableStatusType)

Steps to reproduce

n/a

Expected results

n/a

Actual results

n/a

Regression

n/a

Notes

patch against 1.4 tree, tested with growl notifications triggering only when account is away (and confirmed that they do not trigger when messages are received while account is available).

Attachments (1)

adium-alert_while_away.diff (7.2 KB) - added by jcs 10 years ago.

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by jcs

comment:1 Changed 10 years ago by Robby

  • Milestone set to Adium 1.4
  • Patch Status changed from Initially Included to Needs Dev Review

Thanks! :)

comment:2 Changed 10 years ago by zacw

  • Milestone changed from Adium 1.4 to Adium 1.4.x

New features should *not* be set to 1.4 this late in the cycle. Especially ones that add half-a-dozen new strings, during a string freeze. At minimum, this is a 1.4.1 thing.

comment:3 Changed 10 years ago by Robby

  • Milestone changed from Adium 1.4.x to Adium 1.5

comment:4 Changed 8 years ago by mathuaerknedam

jcs, Does this patch distguish between "normal" messages and groupchat messages? If not, could you add that?

comment:5 Changed 8 years ago by Adrian Godoroja <robotive@…>

(In e5792c806ab3) Added "Message received (Away)" and "Message received (Away Group Chat)" events. Refs #13278.

comment:6 Changed 8 years ago by robotive

  • Patch Status changed from Needs Dev Review to Accepted
  • Resolution set to fixed
  • Status changed from new to closed

No need to, jcs, i did it myself :)
Also, Which name would you like to be credited with?
Thanks!

comment:7 Changed 8 years ago by jcs

"joshua stein"

thanks

comment:8 Changed 8 years ago by Robert Vehse

(In c8a6154d0030) Credit Joshua Stein for his patch. Refs #13278.

Note: See TracTickets for help on using tickets.