Adium

Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#13099 closed defect (fixed)

Сurly bracket { } not allowed in Jabber ID

Reported by: crashtrash Owned by:
Milestone: Adium 1.5 Component: Service/XMPP (Jabber)
Version: 1.3.6 Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description

To reproduce the problem, select Adium on the menu bar, then select Preferences. Click on the plus sign, then click on Jabber to bring up the dialog for creating a new Jabber account. In the Jabber ID field, type a curly bracket { or }. No character will appear. If you type the curly bracket multiple times, you will see an error message: "The characters you're entering are not valid for an account name on this service."

The curly bracket actually is a valid character in a Jabber username. I've used Psi(on Mac) and QIP Infium to sign in to a Jabber server with a username that includes a curly brackets. Example: {Nick}.

Attachments (2)

patch.diff (7.4 KB) - added by mhk 9 years ago.
Patch for ticket
caching.diff (8.0 KB) - added by mhk 9 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 10 years ago by Robby

  • Patch Status Needs Changes by Author deleted

No patch to be seen.

comment:2 Changed 9 years ago by mhk

Implemented support for missing characters in jid.

Changed 9 years ago by mhk

Patch for ticket

comment:3 Changed 9 years ago by paulwilde

  • Patch Status set to Needs Dev Review

comment:4 follow-up: Changed 9 years ago by am

  • Patch Status changed from Needs Dev Review to OK; Needs Check-In

The result of allowedCharactersInNode, allowedCharactersInDomain and allowedCharactersInResource should be cached, but it's not that important.

comment:5 Changed 9 years ago by Robby

  • Milestone set to Adium 1.5

comment:6 in reply to: ↑ 4 Changed 9 years ago by mhk

Replying to am:

The result of allowedCharactersInNode, allowedCharactersInDomain and allowedCharactersInResource should be cached, but it's not that important.

I've implemented some kind of caching by adding ivars for each method and checking for an uninitialized ivar.

Changed 9 years ago by mhk

comment:7 Changed 9 years ago by Marc Kalmes <mkalmes@…>

  • Resolution set to fixed
  • Status changed from new to closed

(In 3efb758fa810) Add support for supported characters in jabber id (fixes #13099)

  • Add method allowedCharactersInNode
  • Add method allowedCharactersInDomain
  • Add method allowedCharactersInResource
  • Change implementation of allowedCharacters to call new methods
  • Change implementation of allowedCharactersForUIDs to call allowedCharacters and new methods

comment:8 Changed 9 years ago by Robby

caching.diff applied in c4c9de82acac.

comment:9 Changed 9 years ago by Robert Vehse

(In b5138ba603c0) Changelog #13099 and give Marc Kalmes credit. Refs #13099.

comment:10 Changed 9 years ago by Robby

  • Patch Status changed from OK; Needs Check-In to Accepted

Thanks :)

Note: See TracTickets for help on using tickets.