Adium

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#13097 closed enhancement (fixed)

Chat transcripts deleted

Reported by: assetburned Owned by:
Milestone: Adium 1.4 Component: Adium UI
Version: Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description

Simply pressing the backspace key shouldn't delete a log. there should be a message for confirmation!

Attachments (3)

wildwobby-13097-101109.diff (972 bytes) - added by Robby Weinberg 11 years ago.
Patch will ask for confirmation when deleting with the backspace button using the already instate confirmation methods.
addition-13097-102809.diff (1.6 KB) - added by William Bowling 11 years ago.
Patch to stop confirmation or try to deletion of 0 selected logs
addition-13097-102809-v2.diff (1.6 KB) - added by William Bowling 11 years ago.
Uses == 1 istead of != 0

Download all attachments as: .zip

Change History (12)

Changed 11 years ago by Robby Weinberg

Attachment: wildwobby-13097-101109.diff added

Patch will ask for confirmation when deleting with the backspace button using the already instate confirmation methods.

comment:1 Changed 11 years ago by Robert

Milestone: Adium 1.4
Patch Status: Needs Dev Review

Go, Robby! :)

comment:2 Changed 11 years ago by Robert

23:29:40 kbotc: #13097 looks pretty good to me..

comment:3 Changed 11 years ago by Zachary West <zacw@…>

Resolution: fixed
Status: newclosed

(In 3d815231bb66) Patch from wildwobby which confirms before removing logs when hitting the delete key. Fixes #13097.

comment:4 Changed 11 years ago by Robert

Patch Status: Needs Dev ReviewAccepted

comment:5 Changed 11 years ago by Zachary West <zacw@…>

(In ff31212ab05e) Patch from wildwobby which confirms before removing logs when hitting the delete key. Fixes #13097.

Changed 11 years ago by William Bowling

Attachment: addition-13097-102809.diff added

Patch to stop confirmation or try to deletion of 0 selected logs

comment:6 Changed 11 years ago by William Bowling

Currently if you press the delete key with no logs selected you get a message asking "Are you sure you want to send 0 logs to the Trash?", not the right behavior I think :)

Also, pressing the delete toolbar button with no logs selected will highlight the last log in the list.

Simple patch to fix

Changed 11 years ago by William Bowling

Uses == 1 istead of != 0

comment:7 Changed 11 years ago by Peter Hosey

Patch Status: AcceptedOK; Needs Check-In

Looks good to me. Checking it in.

comment:8 Changed 11 years ago by Peter Hosey

Pushed as bc1492a4a7c7 in adium-1.4 and b9fd746d2a9a in adium.

comment:9 Changed 11 years ago by Peter Hosey

Patch Status: OK; Needs Check-InAccepted
Note: See TracTickets for help on using tickets.