Adium

Opened 11 years ago

Closed 9 years ago

#11964 closed enhancement (fixed)

Make the "Recent Icons" menu look native on Leopard.

Reported by: Coreh Owned by: robotive
Milestone: Adium 1.5 Component: Adium UI
Version: 1.4hg Severity: minor
Keywords: leopard menu recent icons ui Cc:
Patch Status: Accepted

Description

Hi.

I've made some changes on the way Adium draws the "Recent Icons" menu, so it looks more native in Leopard.

http://imgur.com/EN3y.jpg

I have included a Mercurial export of the Patch. (I'm not sure if I have generated it correctly, since it's the first time I use hg)

Attachments (6)

patch.export (19.1 KB) - added by Coreh 11 years ago.
Patch
new_patch.export (42.9 KB) - added by Coreh 11 years ago.
Patch with binary diffs included
Picture 1.png (36.6 KB) - added by zacw 11 years ago.
Defect with patch applied.
adium-ticket-11964-patch.diff (103.0 KB) - added by ROBOTIVE 9 years ago.
adium-ticket-11964.png (54.7 KB) - added by ROBOTIVE 9 years ago.
should look like this :)
adium-1_5hg-11964.diff (245.2 KB) - added by ROBOTIVE 9 years ago.
rewrite

Download all attachments as: .zip

Change History (29)

Changed 11 years ago by Coreh

Patch

comment:1 Changed 11 years ago by cbarrett

  • Patch Status changed from Needs Dev Review to Needs Discussion

Now that we're leopard only, we should totally rework this to use a real menu with an NSView in it.

comment:2 Changed 11 years ago by Robby

  • Milestone set to Adium 1.4
zac: set it to 1.4

comment:3 Changed 11 years ago by zacw

  • Status changed from new to pending

Hi,

You need to enable git-style diff outputs. In your ~/.hgrc, add:

[diff]
git =

Otherwise, we can't see the binary file changes for this export. Thanks.

comment:4 Changed 11 years ago by zacw

  • Severity changed from normal to minor

Changed 11 years ago by Coreh

Patch with binary diffs included

comment:5 Changed 11 years ago by Coreh

  • Status changed from pending to new

Attachment (new_patch.export) added by ticket reporter.

comment:7 Changed 11 years ago by Coreh

Oh. Thanks! I exported it again.

I hope I got it right this time.

Changed 11 years ago by zacw

Defect with patch applied.

comment:8 Changed 11 years ago by zacw

Hi, I'm seeing the above defect when applying this patch. Also, one comment: you don't need to initialize the value for roundedness to 0, especially not in dealloc. Instance variables begin at 0, and dealloc won't care.

comment:9 Changed 11 years ago by zacw

  • Milestone changed from Adium 1.4 to Adium 1.4.x
  • Patch Status changed from Needs Dev Review to Needs Changes by Author

comment:10 Changed 10 years ago by jas8522

  • Milestone changed from Adium 1.4.x to Adium 1.5

comment:11 Changed 9 years ago by Robby

Any news on this one, Coreh?

comment:12 Changed 9 years ago by Robby

  • Owner nobody deleted

comment:13 Changed 9 years ago by ROBOTIVE

is this ticket still up-to-date? i'm on Snow Leopard and in iChat i can see the same "Recent Icons" menu as used by Adium. There are minor differences like thumbs layout and better arranged elements on Snow Leo's menus, but i can't find there the dashed thumbs.

Last edited 9 years ago by ROBOTIVE (previous) (diff)

comment:14 Changed 9 years ago by Robby

  • Owner set to ROBOTIVE

Changed 9 years ago by ROBOTIVE

Changed 9 years ago by ROBOTIVE

should look like this :)

comment:15 Changed 9 years ago by ROBOTIVE

This can be improved i think, by removing old stuff / or rewriting the whole thing and i'm sure i'll get back to it when i'll feel more comfortable with Adium source :)

Tested on 10.6.6.

Last edited 9 years ago by ROBOTIVE (previous) (diff)

comment:16 Changed 9 years ago by wixardy

  • Patch Status changed from Needs Changes by Author to Needs Dev Review

comment:17 Changed 9 years ago by paulwilde

Nice patch, big improvement. May I add a couple of suggestions:

1) Most menus of these kind seem to have transparency, which (in my opinion) looks better.

2) This is a bit nitpicky (and I'm aware it's not due to your patch, but maybe it's a quick fix), but the contact list becomes inactive when the menu is active, which doesn't happen in other messengers that I tried, and doesn't seem to be the correct behaviour. Maybe I'm wrong on this.

Last edited 9 years ago by paulwilde (previous) (diff)

comment:18 Changed 9 years ago by ROBOTIVE

Hi,

i'm rewriting this menu at the moment (removed a lot of unnecessary things).

  • Now it's a standard Cocoa menu, so it has the transparency, i forgot to add it in the first patch :)
  • I'll take a look at the contact list "issue", maybe it's a quick fix :)

comment:19 Changed 9 years ago by David Munch

Hi Robotive. Are you also going to change the grey background, for empty image wells, into the ones suggested in the initial post? (The ones to the right in the picture) Or at least something a little more pleasing on the eyes.. 8)

Last edited 9 years ago by David Munch (previous) (diff)

Changed 9 years ago by ROBOTIVE

rewrite

comment:19 Changed 9 years ago by Adrian Godoroja <robotive@…>

  • Resolution set to fixed
  • Status changed from new to closed

(In 692222bbfb41) "User Picture Change" menu now uses an NSMenu making it prettier Fixes #11964 Refs #9908

r=wix

comment:20 Changed 9 years ago by Robby

  • Patch Status changed from Needs Dev Review to Accepted

Yummy! :)

comment:21 Changed 9 years ago by robotive

  • Resolution fixed deleted
  • Status changed from closed to new

comment:22 Changed 9 years ago by robotive

  • Owner changed from ROBOTIVE to robotive

comment:23 Changed 9 years ago by robotive

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.