Adium

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#11756 closed enhancement (fixed)

Group chats: chat name tab label

Reported by: pck Owned by:
Milestone: Adium 1.4 Component: Adium UI
Version: 1.3.3 Severity: normal
Keywords: group chat tab label alias text Cc:
Patch Status:

Description

As described in Forum Post #19440: Group chats: member list formatting, and responded to by Robby suggesting I file an Enhancement request:

When I have a contact and assign them an alias, that alias appears as the text of the label on the tab in the chat window when a user-to-user chat is open.

For a related action, setting an alias on a saved group chat seems to only affect the contact-list view of the group chat. the label on the tab of the group chat in the chat window remains the full jid of the multi-user chat. Is there any way to make the tab label in the chat window be the alias rather than the fully qualified jid of the room similar to how a user's alias will be the tab label rather than their full jid?

Change History (8)

comment:1 Changed 11 years ago by zacw

I was thinking about this earlier. The AIListBookmark should set the display name on the AIChat it creates in -openChat.

comment:2 Changed 11 years ago by Robby

  • Milestone set to Good idea for "later"

I guess that means the idea is deemed good. :)l

comment:3 Changed 11 years ago by zacw

(In [26044]) Have AIListBookmark set the displayName for the chat before it opens it. Adds an observer for chats opening so that, if the chat was opened by another means. Fix AIMessageTabViewItem not updating properly when a Display Name changes, since it was watching for the wrong key. However, the delegate it attempts to update is nil. I do not know what to update to trigger a refresh of the label. Refs #11756.

comment:4 Changed 11 years ago by zacw

  • Resolution set to fixed
  • Status changed from new to closed

(In [26045]) When the display name of an AIChat is set, only the display array is updated. Since other things are observing for updates to the @"Display Name" property, this change is never seen. When updating the display name, broadcast an update as well. Fixes #11756.

comment:5 Changed 11 years ago by Robby

  • Milestone changed from Good idea for "later" to Adium 1.4

comment:6 Changed 11 years ago by zacw

(In [26046]) Update the chat display name when an AIListBookmark display name changes. Refs #11756.

comment:7 Changed 11 years ago by zacw

  • Component changed from Group Chat to Adium UI

Removing 'Group Chat' component.

comment:8 Changed 10 years ago by pck

This is very nifty, thank you. A further report, though:

When I have a chat set to "Automatically join on connect", the tab title is set to the JID and even changing the alias in the info panel does not update the tab label. Closing the tab and re-opening by double-clicking on the saved bookmark then displays the group chat alias in the tab label area.

Note: See TracTickets for help on using tickets.