Adium

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11585 closed patch (fixed)

Adium does not deactivate the tune status

Reported by: tomgr Owned by: nobody
Milestone: Adium 1.3.3 Component: Adium Core
Version: Severity: minor
Keywords: Cc:
Patch Status: Accepted

Description

Adium does not deactivate libpurple's tune status when no song is playing which leads to an empty music status being set (consisting of a musical note and a space) rather than no status being set at all.

The attached patch fixes this and was tested with MSN and GTalk. Deactivating the "tune" status is consistent with music plugins for Pidgin.

Attachments (1)

TuneStatus.diff (3.1 KB) - added by Thomas Gibson-Robinson 11 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by Robert

Patch Status: Initially IncludedNeeds Dev Review

Hey tomgr, thanks a lot for your patch! :)
How does this issue relate to the one described in #10490?

Changed 11 years ago by Thomas Gibson-Robinson

Attachment: TuneStatus.diff added

comment:2 in reply to:  1 Changed 11 years ago by Thomas Gibson-Robinson

Replying to Robby:

Hey tomgr, thanks a lot for your patch! :)
How does this issue relate to the one described in #10490?

Hi! It's not the same issue, but I've updated the patch to fix that issue too; though I should add that I've not tested that it does fix that issue, but it should!

comment:3 Changed 11 years ago by Robert

Milestone: Adium 1.3.3
priority: normallow
Severity: normalminor

Thanks a lot! Let's see if we can squeeze this into 1.3.3. :)

comment:4 in reply to:  3 Changed 11 years ago by Thomas Gibson-Robinson

Replying to Robby:

Thanks a lot! Let's see if we can squeeze this into 1.3.3. :)

Thanks Robby!

comment:5 Changed 11 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [25790]) Applied and modified a patch from tomgr which fixes #11585, so that we now properly hide the iTunes now playing information if the preference for an account to broadcast is toggled off and don't show blank song info when no song is playing. Thanks, tomgr!

Fixes #11585. I'm pretty sure this fixes #10490 though I would appreciate confirmation of that.

comment:6 Changed 11 years ago by Evan Schoenberg

(In [25791]) Merged [25790]: Applied and modified a patch from tomgr which fixes #11585, so that we now properly hide the iTunes now playing information if the preference for an account to broadcast is toggled off and don't show blank song info when no song is playing. Thanks, tomgr!

Fixes #11585. I'm pretty sure this fixes #10490 though I would appreciate confirmation of that.

comment:7 Changed 11 years ago by Robert

Patch Status: Needs Dev ReviewAccepted

comment:8 Changed 11 years ago by Thomas Gibson-Robinson

As a small note: this won't work properly until http://developer.pidgin.im/ticket/8162 is fixed - it seems that statuses which are not saveable are being saved, so if you're listening to a song, accounts.xml is written out, then you close adium, then close iTunes and then re-open adium it will still say you're listening to the old song. This seems to be a libpurple bug though since the tune status is not supposed to be saved.

comment:9 Changed 11 years ago by Robert

Thanks, tomgr. :)

Note: See TracTickets for help on using tickets.