Adium

Opened 11 years ago

Closed 8 years ago

Last modified 8 years ago

#11450 closed defect (fixed)

Emoticons between packs are wildly pretty inconsistent.

Reported by: marcel Owned by:
Milestone: Adium 1.5 Component: Adium UI
Version: Severity: minor
Keywords: emoticon parsing Cc:
Patch Status:

Description

The default emoticon packages that ship with Adium define similar sets of emoticons, but the macros used within each are pretty inconsistent. For example, here are the macros that trigger an "angry" smiley:

Adiumy:

:o, >:-o, >:O, >:-O

Default:

:-@, :@, <_<, >:(, >:

iChat:

:o, >:-o, >:O, >:-O

MSN:

:-@, :@, <_<, >:(, >:[, >:

Yahoo:

X(

Default and MSN define "<_<" as an angry face when it's not actually angry at all. "<_<" is widely accepted as a "shifty eyes" emoticon, its compliment is ">_>". Also ">:" doesn't even look like a face. I noticed this issue because a lot of my contacts were quite confused as to why I'm always angry with them. A simple patch to fix that would be as follows:

Index: MSN.AdiumEmoticonset/Emoticons.plist
===================================================================
--- MSN.AdiumEmoticonset/Emoticons.plist	(revision 25649)
+++ MSN.AdiumEmoticonset/Emoticons.plist	(working copy)
@@ -49,10 +49,8 @@
 			<array>
 				<string>:-@</string>
 				<string>:@</string>
-				<string>&lt;_&lt;</string>
 				<string>&gt;:(</string>
 				<string>&gt;:[</string>
-				<string>&gt;:</string>
 			</array>
 			<key>Name</key>
 			<string>Angry</string>
Index: Default.AdiumEmoticonset/Emoticons.plist
===================================================================
--- Default.AdiumEmoticonset/Emoticons.plist	(revision 25649)
+++ Default.AdiumEmoticonset/Emoticons.plist	(working copy)
@@ -30,9 +30,7 @@
 			<array>
 				<string>:-@</string>
 				<string>:@</string>
-				<string>&lt;_&lt;</string>
 				<string>&gt;:(</string>
-				<string>&gt;:</string>
 			</array>
 			<key>Name</key>
 			<string>Angry</string>

But that doesn't fix the overarching inconsistencies between the different packages. If you guys are cool with it I wouldn't mind going through and unifying all the current abstract emoticons into identical macros to keep the behavior between each similar. Let me know first because I don't want to spend a bunch of time fixing that if there's a reason for the madness.

Change History (10)

comment:1 Changed 11 years ago by marcel

Although I guess there's something to say about to keeping the emoticon patterns identical to the clients they represent. At the very least though Default, and Adiumy should be the same, right?

comment:2 Changed 11 years ago by mathuaerknedam

I believe that you are correct in that the goal is for the bundled protocol-specific emoticon packs to mirror the official client for that protocol.

comment:3 follow-up: Changed 11 years ago by marcel

Yeah definitely. I just looked at this in MSN Messenger on PC and only ":-@" and ":@" were translated to angry faces. ">:(" turned into ">"+sad face. ">:[" turned into ">"+bat (like the rodent). The others remained unchanged. So it seems at the very least "<_<", ">:(", ">:[", and ">:" should be removed from MSN's package. It seems reasonable to also remove those from Default's definition.

Could someone loop evands into this ticket? He's been the primary committer to /Emoticons/. I can't seem to edit this ticket even though I added :[.

comment:4 Changed 11 years ago by Robby

  • Keywords emoticon parsing added

comment:5 Changed 11 years ago by Robby

  • Component changed from Message View to Adium UI
  • Owner set to nobody

comment:6 Changed 11 years ago by Robby

  • Milestone set to Adium 1.3.x
  • priority changed from normal to low
  • Severity changed from normal to minor

Let's investigate this emoticon stuff for the next minor release.

comment:7 Changed 9 years ago by Robby

  • Owner nobody deleted

comment:8 Changed 9 years ago by Robby

  • Milestone changed from Adium 1.4.x to Adium bugs

comment:9 Changed 8 years ago by Frank Dowsett <wixardy@…>

  • Resolution set to fixed
  • Status changed from new to closed

(In e4730679faf7) Remove some angry emoticon shortcuts fixes #11450

comment:10 in reply to: ↑ 3 Changed 8 years ago by wixardy

  • Milestone changed from Adium bugs to Adium 1.5

Replying to marcel:

bat (like the rodent)

You mean mammal.

Note: See TracTickets for help on using tickets.