Adium

Opened 11 years ago

Closed 9 years ago

Last modified 9 years ago

#11389 closed defect (fixed)

"Insert Link To Active Page in [Browser]" toolbar button does not work with NetNewsWire

Reported by: hmelman Owned by: nobody
Milestone: Adium 1.5 Component: Adium Core
Version: 1.3.5 Severity: minor
Keywords: Cc:
Patch Status:

Description

Same as ticket #11039. Adium 1.3.2, OS X 10.5.5.

With one browser (safari 3.2) running, the Insert Link toolbar button in a conversation works. If I open a second browser (NetNewsWire 3.1.7) then hitting that button just results in a beep. Quitting NNW and leaving Safari running, the button works again. Restarting NNW (with Safari still running) and it fails again. It behaves the same way whether or not NNW is on a web page tab or the News Items tab (if on the News Item tab I would expect there to be no conflict with Safari and Safari's URL should be used).

With Safari or both running, inserting the string %_safari works properly.

A friend recreated the above behavior (button and %_safari) on a different machine running 10.5.5 with Firefox 3.0.4 and NetNewsWire 3.1.7. Neither of us have any Adium plugins installed.

For me typing cmd-K causes a sheet to appear with two fields, the name is blank and the URL is filled in only if there is an URL on the clipboard (regardless of how many "browsers" are running). This is unfortunately much slower for just inserting the current browser page, so isn't a good workaround.

Change History (10)

comment:1 Changed 11 years ago by zee

Same here, safari 3.2.1 and netnewswire 3.1.7.

comment:2 Changed 10 years ago by Robby

  • Status changed from new to pending

Does this remain a problem in 1.3.5?

comment:3 Changed 10 years ago by hmelman

  • Status changed from pending to new

Yes, still a problem in 1.3.5.

comment:4 Changed 10 years ago by Robby

  • Version changed from 1.3.2 to 1.3.5

comment:5 Changed 10 years ago by Robby

  • Milestone set to Adium bugs
  • Severity changed from normal to minor

comment:6 Changed 10 years ago by baadpuppy

This still happens with Adium 1.3.8 and NetNewsWire 3.2.3.

In my testing, it seems that the Adium.app/Contents/Resources/Safari.scpt applescript isn't compatible with newer NetNewsWire versions. If I open the script in the AppleScript editor and remove all the NetNewsWire section, it works correctly again.

It annoys me every time I update to have to go do that change again.

comment:7 Changed 9 years ago by hmelman

I don't think it's a NetNewsWire issue. Editing the Safari.scpt to remove "with prompt severalBrowsersPrompt" seems to solve the problem.

comment:8 Changed 9 years ago by Frank Dowsett <wixardy@…>

  • Resolution set to fixed
  • Status changed from new to closed

(In fb6284e51795) Fix #11389 NetNewsWire link insertion, one of those off-by-one errors.

comment:9 Changed 9 years ago by Robby

  • Milestone changed from Adium bugs to Adium 1.5

comment:10 Changed 9 years ago by Robby

  • Summary changed from "Insert Link To Active Page in [Browser]" toolbar button not working to "Insert Link To Active Page in [Browser]" toolbar button does not work with NetNewsWire
Note: See TracTickets for help on using tickets.