Adium

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11364 closed defect (fixed)

Account connect w/PAC file results in multiple CriticalAlertPanels

Reported by: nrh Owned by: nobody
Milestone: Adium 1.4 Component: Adium Core
Version: 1.3.2 Severity: normal
Keywords: Cc:
Patch Status:

Description

Summary: on/around Frameworks/AIUtilities\ Framework/Source/AISystemNetworkDefaults.m:126, an NSRunCriticalAlertPanel is generated for every account that has 'use system-wide proxy information' checked when there is a PAC-file configured globally.

Use case:

  1. User uses location switching to switch between proxy-autoconfig via file and manual proxy configuration via socks
  2. User wishes Adium to use socks configuration when using socks-configured location
  3. User wishes Adium to use no proxy config when using proxy-autoconfig file-configured location

In #3 above, an NSRunCriticalAlertPanel, blocking account connection, is generated for every account on every connect. This is hella annoying and the only way around it is to iterate through every account and disable the "use system-wide proxy" preference.

I suggest a better option would be to display a growl notification for the warning indicating that the system-wide PAC file can't be used. this would not block the connection from establishing and would be generally much less annoying.

Change History (4)

comment:1 Changed 11 years ago by evands

  • Resolution set to fixed
  • Status changed from new to closed

(In [25577]) This might implement PAC support for proxy configuration. Fixes #224 if so. Fixes #11364 if so.

Needs testing.... I use neither a proxy nor a PAC file and can't test it. :)

comment:2 Changed 11 years ago by evands

nrh: Could you please try Adium_1.4svn20081113.dmg and let us know if this fixes PAC support for you?

comment:3 Changed 11 years ago by Robby

  • Milestone set to Adium 1.4

comment:4 Changed 11 years ago by zacw

  • Component changed from AIUtilities.framework to Adium Core

Removing AIUtilities component.

Note: See TracTickets for help on using tickets.