Adium

Opened 14 years ago

Closed 14 years ago

Last modified 9 years ago

#1118 closed enhancement (fixed)

Adium does not import the Middle name from Address Book entries.

Reported by: danny506@not_for_spam_gmail.com Owned by: byped
Milestone: Adium X 1.0 Component: Adium Core
Version: Severity: minor
Keywords: Address Book, Middle Cc:
Patch Status: Accepted

Description

In Preferences / Advanced / Address Book, there are only options to import First and Last name from the Address Book. As I have filled in a middle name (like 'van') for several of my Address Book contacts, so they are correctly sorted in by their Last name, I have noticed that Adium does not support this.

It would be nice if Adium has the possibility to have the Middle name imported from the Address Book entries. This would also mean Preferences / Advanced / Address Book would have to provide options like 'First Middle Last', 'Last, First Middle' to be imported from the Address Book.

Attachments (2)

middleNames.diff (11.9 KB) - added by byped 14 years ago.
Patch to add middle names from the address book
middleNames2.diff (11.4 KB) - added by anonymous 14 years ago.
the previous patch would put (null) in for the middle name if it didn't exist, this fixes that

Download all attachments as: .zip

Change History (11)

comment:1 Changed 14 years ago by Evan Schoenberg

Milestone: Adium X 0.90

I don't think this would be difficult or problematic; milestoning to review for possible implementation.

comment:2 Changed 14 years ago by Colin Barrett

Owner: changed from nobody to Colin Barrett
Status: newassigned

*snatch* :)

comment:3 Changed 14 years ago by Colin Barrett

Owner: changed from Colin Barrett to byped
Status: assignednew

byped is going to work on this, I'll review his patch.

Changed 14 years ago by byped

Attachment: middleNames.diff added

Patch to add middle names from the address book

comment:4 Changed 14 years ago by byped

This should do it, let me know if there's anything I overlooked.

Changed 14 years ago by anonymous

Attachment: middleNames2.diff added

the previous patch would put (null) in for the middle name if it didn't exist, this fixes that

comment:5 Changed 14 years ago by Colin Barrett

Resolution: fixed
Status: newclosed

(In [13727]) Applying bypeds patch, with minor changes (evan's middle name is not M, it's Dreskin). Fixes #1118

comment:6 Changed 14 years ago by Colin Barrett

(In [13728]) Merging [13727]: Applying bypeds patch, with minor changes (evan's middle name is not M, it's Dreskin). Fixes #1118

comment:7 Changed 14 years ago by Evan Schoenberg

(In [13777]) Let's not randomly change people's preferences. Reordering an enum which is being stored as a preference makes preferences randomly change. Furthermore, reordering an enum such that the default changes when the default was better before (making the '0' value be First rather than FirstLast, in this case), is also problematic. Refs #1118.

comment:8 Changed 14 years ago by Evan Schoenberg

(In [13778]) Let's not randomly change people's preferences. Reordering an enum which is being stored as a preference makes preferences randomly change. Furthermore, reordering an enum such that the default changes when the default was better before (making the '0' value be First rather than FirstLast, in this case), is also problematic. Refs #1118. Merged [13777]

comment:9 Changed 9 years ago by Robert

Patch Status: Accepted
Note: See TracTickets for help on using tickets.