Adium

Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#1117 closed enhancement (fixed)

Block Contact Toolbar Icon

Reported by: victor.andree@gmail.com Owned by: kiel
Milestone: Adium X 1.0 Component: Adium UI
Version: Severity: minor
Keywords: toolbar icon block starter Cc: kgilla10@…
Patch Status:

Description

I really think there should be a "Block/Unblock contact"-icon in the IM-window toolbar.

Attachments (2)

huh.diff (10.3 KB) - added by kiel 14 years ago.
Blasted patch
huh2.diff (10.6 KB) - added by kiel 14 years ago.
Same patch riddled with NSLogs

Download all attachments as: .zip

Change History (28)

comment:1 Changed 14 years ago by Zachary West

Duplicate of #1100 (though #1100 is worded strangely).

comment:2 Changed 14 years ago by Zachary West

Summary: Block Contact in toolbar?Block Contact Toolbar Icon

The summary really shouldn't be a question. Also, I should note that #1100 was marked as a duplicate of this due to its confusing description.

comment:3 Changed 14 years ago by Kiel Gillard

I'm working on ticket #344 and I'll be able to implement something like this as well if you'd like. I know some IM users that would appreciate a feature like this. If you need to contact me, kgilla10@… is my email address.

comment:4 Changed 14 years ago by David Smith

Milestone: Adium X 1.0

comment:5 Changed 14 years ago by Evan Schoenberg

field_haspatch: 0
Owner: changed from nobody to Kiel Gillard

comment:6 Changed 14 years ago by Kiel Gillard

Ok, how does this sound:
1) Message Window block button: allows the user to block/unblock the buddy the user has the conversation window open for.
2) Contact List block button: allows the user to block/unblock selected contact(s) on the contact list. If some of the selected contacts are already blocked, only those that are unblocked will be blocked. The proposed plugin will only unblock a group of selected contacts who are all blocked.

If the above proposed ideas are kosher with the devs and with the closure of ticket 344 at hand, privacy in Adium should turn out pretty nicely for users in 1.0.

comment:7 Changed 14 years ago by Evan Schoenberg

Kiel, that sounds like good behavior to me. Contact->Block / Contact->Unblock should behave as you describe in (2) above, since it could be called with multiple contact list items selected.

comment:8 Changed 14 years ago by Evan Schoenberg

Cc: kgilla10@… added

comment:9 Changed 14 years ago by Colin Barrett

Evan, isn't that the way that menu behaves now? If not, it should. My only comment about 2) is that it seems to say that unblocking a group of contacts that have a heterogeneous state (i.e. some are blocked, some are not) would be a no-op or display an error; I think that's silly. If they are already unblocked, awesome! Less work for the code to do ;-)

comment:10 Changed 14 years ago by Kiel Gillard

Allow me to clarify:

  1. If some of the selected contacts are blocked, only those that are not blocked will be blocked. So at the end of the operation, all the selected contacts will be blocked. With visual notification of blocked contacts, users will be able to clearly see that all the selected contacts are blocked.


  1. Unblocking only occurs when all the selected contacts are blocked.



None of the menus allow the user to block/unblock multiple contacts at the same time.

comment:11 Changed 14 years ago by Samomo6485@…

please tell me how I can unblock a buddy. thanks!

comment:12 Changed 14 years ago by Peter Hosey

samomo6485: Trac tickets are not for support requests. you should go to the forums and ask your question there.

comment:13 Changed 14 years ago by Kiel Gillard

The same way you blocked your buddy. Choose the contact in the contact list and control click and choose Unblock or choose Contact > Unblock from the menu bar.

I don't understand why this is hard/confusing for people to find or do...

comment:14 Changed 14 years ago by Peter Hosey

I think the source of the confusion is that blocked buddies seem to go offline, so they disappear. fortunately, we have a menu item command for that.

comment:15 Changed 14 years ago by David Smith

Keywords: starter added

comment:16 Changed 14 years ago by kiel

Owner: changed from Kiel Gillard to kiel
Status: newassigned

comment:17 Changed 14 years ago by kiel

Can someone please tell me why the toolbar item isn't executing the action when ?

I have no problems blocking and unblocking contacts when there's a visible icon in the toolbar, but when it's just a textual representation of the toolbar item, the action is not even called.

To reproduce, apply the patch, add the block icon to your message view toolbar, command-click the show/hide toolbar widget in the message view's title bar until the toolbar items are represented as text only and attempt to block/unblock a contact.

It has me stumped.

Changed 14 years ago by kiel

Attachment: huh.diff added

Blasted patch

comment:18 Changed 14 years ago by kiel

Take 2:

Can someone please tell me why the toolbar item isn't executing the action assigned to it when the toolbar item is shown in text only mode?

I have no problems blocking and unblocking contacts when there's a visible icon in the toolbar, but when it's just a textual representation of the toolbar item, the action is not even called.

To reproduce, apply the patch, add the block icon to your message view toolbar, command-click the show/hide toolbar widget in the message view's title bar until the toolbar items are represented as text only and attempt to block/unblock a contact.

It has me stumped.

Changed 14 years ago by kiel

Attachment: huh2.diff added

Same patch riddled with NSLogs

comment:19 Changed 14 years ago by kiel

In [15593], fixed a bug that solves the problem I was having with this patch. Will commit a patch to address this ticket in a week if I don't hear any complaints about the changes made in [15593].

comment:20 Changed 14 years ago by Evan Schoenberg

While I haven't noticed any problems with [15593] yet, I'm left scratching my head as to why such a huge block of code was written if the copy method actually works as promised ;)

comment:21 Changed 14 years ago by David Smith

Milestone: Adium X 1.0Adium X 1.1

If this is going in, feel free to move it back. If not, we're not gonna block on it.

comment:22 Changed 14 years ago by kiel

Milestone: Adium X 1.1Adium X 1.0

It's going in.

comment:23 Changed 14 years ago by kiel

Resolution: fixed
Status: assignedclosed
Version: 1.0

(In [15618]) Providing a Block/Unblock toolbar item for message windows. Closes 1117.

comment:24 Changed 14 years ago by anonymous

World of Warcraft gold(wow gold)--buy cheap,sell wow goldwelcome to buy cheap --cheap, easy, purchasing.World of Warcraft,Super fastdelivery of gold, items,and accounts

China's first cartoon play Dreamland will debut on Children's Day 2006. The play will be produced by CCTV's children's channel and promoted by the China Perfoming Arts Agency(wow gold), perhaps best known as the Chinese agent for Disney on Ice during the past two years.come on Over the last 20 years, CCTV has always presented a variety show on June 1, the No.1 TV programme on that day. Aiming to produce China's grandest cartoon play, CCTV and other eight governmental organs called on world of warcraft gold China's best producers, dirctors, please come on actors and actresses and stage technicians to help create this marvel.

comment:25 in reply to:  description Changed 14 years ago by anonymous

Resolution: fixed
Status: closedreopened

Replying to victor.andree@gmail.com:

I really think there should be a "Block/Unblock contact"-icon in the IM-window toolbar.

comment:26 Changed 14 years ago by kiel

Resolution: fixed
Status: reopenedclosed

I really think you should check your facts before you reopen tickets.

Note: See TracTickets for help on using tickets.