Adium

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#10996 closed defect (fixed)

Wrong string used for emoticons, AdiumyEmoticonSet

Reported by: acollign Owned by: nobody
Milestone: Adium 1.3.2 Component: Xtras
Version: Severity: normal
Keywords: Cc: feedback@…
Patch Status: Accepted

Description

A mistake has been made in the Emoticons.plist file of the AdiumyEmoticonSet.

String entry of (Name key of) wub.png key is set to 'Kiss' instead of 'Lips are Sealed' or something like that. As a consequence, the name of the wub.png in emoticons list is set to Kiss (see the attached pic).

My 2cts

--- /Volumes/Home/acollign/Temp/adium/Resources/Emoticons/Adiumy.AdiumEmoticonset/Emoticons.plist	2008-09-04 18:29:21.000000000 +0200
+++ /Volumes/Home/acollign/Desktop/Emoticons.plist	2008-09-08 11:29:30.000000000 +0200
@@ -120,7 +120,7 @@
 				<string>:X</string>
 			</array>
 			<key>Name</key>
-			<string>Kiss</string>
+			<string>Lips are Sealed</string>
 		</dict>
 		<key>money.png</key>
 		<dict>

Attachments (2)

wrong_label-lips_are_sealed.png (41.1 KB) - added by Alexandre COLLIGNON 11 years ago.
adiumy.2.diff (406 bytes) - added by Alexandre COLLIGNON 11 years ago.
patch

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by Alexandre COLLIGNON

comment:1 Changed 11 years ago by Robert

Milestone: Adium 1.3.2

comment:2 Changed 11 years ago by mathuaerknedam

Cc: feedback@… added
Component: Adium CoreXtras
Patch Status: NoneNeeds Dev Review

Here's a patch.

Changed 11 years ago by Alexandre COLLIGNON

Attachment: adiumy.2.diff added

patch

comment:3 Changed 11 years ago by Alexandre COLLIGNON

Sorry mathuaerknedam, but you're wrong. Your patch changes the string of the correct smiley, have a look to the first line (<string>:*</string>).

I copy the patch given in the description to the file adiumy.2.diff

comment:4 Changed 11 years ago by mathuaerknedam

Oops, you're right! I'll delete my patch.

comment:5 Changed 11 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [25165]) Patch from acollign to fix the 'Lips Are Sealed' emoticon in the Adiumy set to be named properly. Fixes #10996

comment:6 Changed 11 years ago by Evan Schoenberg

(In [25166]) Merged [25165]: Patch from acollign to fix the 'Lips Are Sealed' emoticon in the Adiumy set to be named properly. Fixes #10996

comment:7 Changed 11 years ago by Robert

Patch Status: Needs Dev ReviewAccepted
Note: See TracTickets for help on using tickets.