Adium

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#10912 closed defect (fixed)

iChat transcript import fails for transcripts with inline images

Reported by: stewa Owned by: nobody
Milestone: Adium 1.3.1 Component: Adium Core
Version: Severity: normal
Keywords: Cc:
Patch Status: Rejected

Description

iChat transcripts with inline images can't be imported. The wizard either freezes or just continues without importing further transcripts. Out of my 2300 transcripts it ended up importing just 240 after removing the ones casing the wizard to freeze. Attached path fixes the crash issue. It still doesn't import any inline images bit that doesn't seem to be a supported feature?

Attachments (1)

adium_ichat_import.diff (797 bytes) - added by Stefan Wallström 12 years ago.

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by Stefan Wallström

Attachment: adium_ichat_import.diff added

comment:1 Changed 12 years ago by Robert

Milestone: Adium 1.3.2
Patch Status: Initially IncludedNeeds Dev Review

Thanks for your contribution! :)

comment:2 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [25125]) We can now import the images in iChat Transcripts rather than throwing an exception. Thanks to stewa in #10912 for noting the location of the previous exception and providing a patch to workaround the issue; this commit instead fixes it. Fixes #10912.

comment:3 Changed 12 years ago by Evan Schoenberg

Milestone: Adium 1.3.2Adium 1.3.1

comment:4 Changed 12 years ago by Evan Schoenberg

(In [25126]) Merged [25125]: We can now import the images in iChat Transcripts rather than throwing an exception. Thanks to stewa in #10912 for noting the location of the previous exception and providing a patch to workaround the issue; this commit instead fixes it. Fixes #10912.

comment:5 Changed 12 years ago by Robert

Patch Status: Needs Dev ReviewAccepted

comment:6 Changed 12 years ago by Evan Schoenberg

Patch Status: AcceptedRejected

comment:7 Changed 12 years ago by Robert

Oops. :D

Note: See TracTickets for help on using tickets.