Adium

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#10868 closed patch (fixed)

patch to allow fallback to root-level content.html

Reported by: mathuaerknedam Owned by: cbarrett
Milestone: Adium 1.4 Component: Message View
Version: 1.4hg Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description

It would be nice if the optional messagestyle files were expanded a bit from the implementation described in CreatingMessageStyles. With this patch, Adium will look for Content.hmtl in Resources/ if Resources/Incoming/Content.html is not present. Similarly, Adium will look for Content.hmtl in Resources/ if Resources/Status.html is not present.

It's all optional and breaks nothing. As I start rewriting MessageStyleTutorial, I'd like to make it as simple as possible. With this patch, Resources/ needs only contain Content.html and Main.css. Toward this end, I'd appreciate it if this could be included in the next release (I know, everybody wants this!) so that I can work on the docs. I made the patch with trunk, do I also need to make a patch for 1.3?

(I'll try to followup with patches that enable some of the Status.html-specific keywords to also work in Content.html in order to minimize any loss of functionality and increase flexibility. I'll post those patches to the relevant existing tickets. :)

Attachments (2)

rootcontent.diff (2.7 KB) - added by mathuaerknedam 11 years ago.
rootcontent2.diff (2.7 KB) - added by mathuaerknedam 11 years ago.
updated patch where Status.html will fallback to Incoming/Content.html

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by mathuaerknedam

comment:1 Changed 11 years ago by mathuaerknedam

  • Type changed from defect to patch

comment:2 Changed 11 years ago by cbarrett

  • Milestone set to Adium 1.4

I know it will break your heart but how about keeping this for 1.4? It's clearly a new feature and does not really fix an existing bug or issue.

comment:3 Changed 11 years ago by mathuaerknedam

As you state, keeping it for 1.4 would be disappointing. However, I do understand the rationale and I can't really make a good argument against it.

After thinking about this a bit more, I decided that it would be safer to have Status.html fall back to Incoming/Content.html rather than a root-level Content.html. I'm adding a second patch for that.

Changed 11 years ago by mathuaerknedam

updated patch where Status.html will fallback to Incoming/Content.html

comment:4 Changed 11 years ago by cbarrett

  • Patch Status changed from Initially Included to OK; Needs Check-In

comment:5 Changed 11 years ago by cbarrett

  • Owner set to cbarrett

comment:6 Changed 11 years ago by cbarrett

  • Resolution set to fixed
  • Status changed from new to closed

(In [25083]) Patch from mathuaerknedam. Add fallbacks to root level files for Status.html and Content.html. Closes #10868.

comment:7 Changed 11 years ago by Robby

  • Patch Status changed from OK; Needs Check-In to Accepted
Note: See TracTickets for help on using tickets.