Adium

Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#10594 closed patch (fixed)

iPhone OS support for AutoHyperlinks

Reported by: mikeabdullah Owned by: earthmkii
Milestone: Component: AutoHyperlinks
Version: 1.3svn Severity: normal
Keywords: iphone Cc:
Patch Status:

Description

The iPhone SDK does not support NSAttributedString, but AutoHyperlinks is still some very handy code to have there. To work around, this patch:

A) Doesn't include any NSAttributedString-dependent methods when compiling for the iPhone.
B) Adds a new companion method -[AHHyperlinkScanner linkifiedHTML] as a companion to to -linkifiedString.

Attachments (1)

iphone.diff (5.0 KB) - added by mikeabdullah 6 years ago.
Patch

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by mikeabdullah

Patch

comment:1 Changed 6 years ago by jas8522

  • Milestone set to Adium X 1.3.x
  • Summary changed from iPhone OS support to iPhone OS support for AutoHyperlinks

comment:2 Changed 6 years ago by earthmkii

  • Cc feedback@… removed
  • Milestone changed from Adium X 1.3.x to Good idea for "later"
  • priority changed from normal to low
  • Status changed from new to assigned

Cool! I don't have time to inspect/test this right away, but just making a note that I'm aware of it :)

comment:3 Changed 6 years ago by zacw

  • Patch Status changed from Initially Included to Needs Dev Review

comment:4 Changed 5 years ago by cbarrett

  • Patch Status changed from Needs Dev Review to Needs Changes by Author

Mike:

Just curious, how did you test this? Also, how can others test this in the future to verify that it in fact, hasn't broken.

Other than that this looks fine.

comment:5 Changed 5 years ago by Mike Abdullah

  • Resolution set to fixed
  • Status changed from assigned to closed

(In 0e0e38e66cf2) Add iPhone SDK support to AutoHyperlinks. Fixes #10594

comment:6 Changed 5 years ago by Catfish_Man

  • Resolution fixed deleted
  • Status changed from closed to new

Reopening this since that commit was meant to be local only for testing.

comment:7 Changed 4 years ago by earthmkii

  • Resolution set to fixed
  • Status changed from new to closed

AH supports this now.

comment:8 Changed 4 years ago by Robby

  • Milestone Good idea for "later" deleted
  • Patch Status Needs Changes by Author deleted
Note: See TracTickets for help on using tickets.