Adium

Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#10496 closed defect (fixed)

Newlines in message history are doubled

Reported by: rgovostes Owned by: nobody
Milestone: Component: Adium Core
Version: Severity: regression
Keywords: Cc:
Patch Status:

Description

Although handling newlines was improved in [24382], there seems to be a regression in that newlines in the message history get doubled up (probably two <BR>s).

Change History (6)

comment:1 Changed 12 years ago by Robert

Milestone: Adium X 1.3

comment:2 Changed 12 years ago by Evan Schoenberg

I was seeing this bug before [24382].

comment:3 Changed 12 years ago by Evan Schoenberg

The XML log is being written out correctly, with a single <br /> tag per newline. When read in by the message history class, we get <br><br />.

comment:4 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [24398]) AIXMLElement depends upon knowing that a tag self-closes; otherwise, it closes it. We therefore need to know that <br /> is a self-closing tag. AIHTMLDecoder sets this explicitly when encoding, but when decoding the tag was not previously known to self-close. Newlines therefore before <br><br /> rather than just <br />. Fixes #10496.

comment:5 Changed 12 years ago by Robert

Milestone: Adium X 1.3SVN issues

comment:6 Changed 11 years ago by (none)

Milestone: SVN issues

Milestone SVN issues deleted

Note: See TracTickets for help on using tickets.