Adium

Opened 12 years ago

Closed 12 years ago

#10257 closed defect (fixed)

Dragging and dropping a contact into the last position in a group puts it in the first group in the contact list

Reported by: jas8522 Owned by: nobody
Milestone: Adium 1.3 Component: Adium UI
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description (last modified by Jordan)

1.3svn (approximately 1.3b4) [24101] with OS X 10.5.3

Steps to Reproduce:

  1. Choose a contact that is not the last contact in a group that is not the first group in your contact list
  2. Attempt to drag and drop the contact into the last position in its group (ie: between the last contact and the title of the next group)
  3. Notice that the drop 'bar' that normally appears between contacts does not show up between the last contact and the title of the next group (where you are trying to drop it). Instead the title of the first group in your contact list has the highlighting on it - it appears as if you are hovering over that instead.
  4. Drop the contact by letting go of the mouse button and you'll notice that it actually gets placed in the first group in your last rather than where you wanted it (in the last position of the group it currently resides in).

I expected two things to occur differently than they did. First, I expected the drop 'bar' to appear between the last contact and the next group title, and second I expected the contact to get placed where I dropped it.

We need to be careful here to check that the fix for this does not cause confusion when people are dropping a contact between the last subcontact in an expanded metacontact and the contact that is right after the metacontact. There are two potential drop positions here:

  1. As a subcontact of the metacontact - at the bottom of its list of subcontacts, and
  2. As a normal contact directly after the metacontact

The bars will be nearly identical, assumably with a slight margin being the only difference between them. Perhaps we could differentiate them by color? When dropping within a metacontact or on a metacontact, the highlight color/dropbar color is green rather than blue or something like that?

Change History (5)

comment:1 Changed 12 years ago by Jordan

Description: modified (diff)

comment:2 Changed 12 years ago by Jordan

Milestone: Adium X 1.3.2Adium X 1.3

I made a guess that #10255 is actually the same as this in my comment in that ticket, but I'm not positive that this is the case. If it is, then this should be fixed for 1.3 and the fix for this will likely also fix #10255 (or the consideration of #10255 must be taken when fixing this). For this reason I'm putting this back to 1.3 as expanding metacontacts exacerbates this problem.

comment:3 Changed 12 years ago by Evan Schoenberg

We need to be careful here to check that the fix for this does not cause confusion when people are dropping a contact between the last subcontact in an expanded metacontact and the contact that is right after the metacontact. There are two potential drop positions here:

When dropping within the metacontact, the metacontact is highlighted in blue, whereas when dropping within a group, the group is highlighted in blue.

comment:4 Changed 12 years ago by Jordan

Ahh yes - excellent. So there's no problem with any confusion there. Just the bug - in that dropping the contact in the last position provides no position indicator, and drops it in the first group instead.

comment:5 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [24109]) Fixed drag&drop to the bottom of groups. This bug has been around forever. Round of applause to jas8522 for superb steps to reproduce which made this easy to fix :) Fixes #10257

Note: See TracTickets for help on using tickets.