Adium

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#10174 closed defect (fixed)

%status% shouldn't contain "history"

Reported by: mathuaerknedam Owned by:
Milestone: Adium 1.3.3 Component: Message View
Version: Severity: regression
Keywords: Cc: David Smith
Patch Status:

Description

As of r24019...

Date separators in message history return a %status% of "date_separator history", but history isn't really part of the status. As far as I can tell, date separators are the only type of status or event that appears in message history, so this is probably the only place where "history" appears incorrectly.

Change History (10)

comment:1 Changed 12 years ago by Jordan

Cc: David Smith added
Milestone: Adium X 1.3

comment:2 Changed 12 years ago by Jordan

Severity: normalregression

comment:3 Changed 12 years ago by Evan Schoenberg

Resolution: wontfix
Status: newclosed

It -is- a historical date separator, though, and if you are controlling the display of all history (e.g. fading it relative to current messages) you want to be able to fade the date separator appropriately, too.

comment:4 Changed 12 years ago by Robert

Milestone: Adium X 1.3

comment:5 Changed 12 years ago by mathuaerknedam

Resolution: wontfix
Status: closedreopened

I think you might be confusing %status% with %messageclasses%. After you closed the ticket I reread this and couldn't figure out why I had opened it. Alternative, I may be misunderstanding the use of %status%.

%messageclasses% does correctly contain date_seperator and history, and gets used exactly as you suggest. As I understand it %status% is available only in status.html and is used to determine exactly what type of status message is being displayed. This is they way it's use is described in #CreatingMessageStyles. "history" is not a type of status message, it's a class that some status messages might have (like they used to have the class "incoming").

comment:6 Changed 12 years ago by Robert

Milestone: Good idea for "later"

comment:7 Changed 11 years ago by Robert

Milestone: Good idea for "later"Adium bugs

comment:8 Changed 11 years ago by Robert

Milestone: Adium bugsAdium 1.3.3

As it's a regression...

comment:9 Changed 11 years ago by Evan Schoenberg

Resolution: fixed
Status: reopenedclosed

(In [25698]) Don't include 'history' in the %status% of a date separator in history; this should instead be included as a display class. Fixes #10174

comment:10 Changed 11 years ago by Evan Schoenberg

(In [25699]) Merged [25698]: Don't include 'history' in the %status% of a date separator in history; this should instead be included as a display class. Fixes #10174

Note: See TracTickets for help on using tickets.