Static Analysis of Adium

This page lists the reports generated by  Clang Static Analyzer as run on r24417. This page can be used by developers to investigate each report and make a ruling on its validity.

This page is updated periodically, so reports marked as false positives previously may appear to have no ruling in the table below. Please consult the page's revision history and update the current page if there is a discrepancy.

Key

	No ruling
Y	Confirmed report, ticket open
Y	Confirmed report, ticket closed
[changeset:4 F]	Confirmed report, fixed without a ticket
N	False positive

Reports

	Data	Comment
N	memory leak in  AIFacebookOutgoingMessageManager.m:34	(repeat of  this) Originally a true leak (Y), now a false positive
N	memory leak in  ESPurpleJabberAccountViewController.m:209	(repeat of  this) When err is set, the method returns nil.
	memory leak in  AsyncSocket.m:1584
	memory leak in  AIFacebookStatusManager.m:27
N	memory leak in  AIFacebookOutgoingMessageManager.m:54	(repeat of  this) Originally a true leak (Y), now a false positive
N	memory leak in  EKEzvIncomingFileTransfer.m:301	(repeat of  this) Originally a true leak (Y), now a false positive
F	memory leak in  BGEmoticonMenuPlugin.m:307
N	memory leak in  AIMessageViewController.m:528	(repeat of  this)
	memory leak in  AsyncSocket.m:1584
	memory leak in  AsyncSocket.m:1560
N	memory leak in  AIPurpleCertificateViewer.m:49	(repeat of  this)
Y	memory leak in  HTTPServer.m:460	(repeat of  this) Finished fixing in [changeset:24418 [24418]]
	memory leak in  AsyncSocket.m:1560
N	bad argument in  NSString-FBAdditions.m:47	(repeat of  this) f is a pointer to fch, and is passed to a function that initializes fch through it
	dead initialization in  EKEzvIncomingFileTransfer.m:174
	dead initialization in  RBSplitView.m:682
[changeset:24421 F]	dead initialization in  CTGradient.m:55
	dead initialization in  RBSplitView.m:670
	dead initialization in  CTGradient.m:1199
	dead initialization in  RBSplitSubview.m:687
	dead initialization in  EKEzvIncomingFileTransfer.m:173
	dead initialization in  EKEzvIncomingFileTransfer.m:171
	dead store in  AIListController.m:683
Y	dead store in  NSCalendarDate+ISO8601Parsing.m:236
	dead store in  fribidi.c:640
[changeset:24420 F]	dead store in  AIAddressBookUserIconSource.m:73
	dead store in  ESTextAndButtonsWindowController.m:369
[changeset:24352 F]	dead store in  AWEzvXMLStream.m:175	(repeat of  this, +17 lines) Finished fixing in [changeset:24419 [24419]]
	dead store in  packtab.c:179
F	dead store in  AIAlternatingRowOutlineView.m:152
	dead store in  fribidi.c:635
	dead store in  RBSplitView.m:977
	dead store in  SRCommon.m:242
	dead store in  sha1.c:104
	dead store in  fribidi_char_sets_cap_rtl.c:116
	dead store in  fribidi_char_sets_cap_rtl.c:242
	dead store in  IconFamily.m:1028
	dead store in  fribidi.c:738
	dead store in  fribidi.c:739
	dead store in  AIAttributedStringAdditions.m:167
	dead store in  SLPurpleCocoaAdapter.m:1139
	dead store in  DCPurpleZephyrJoinChatViewController.m:63
F	dead store in  AIAlternatingRowOutlineView.m:150
	dead store in  GBFireImporter.m:354
	dead store in  fribidi.c:736
	dead store in  ESSendMessageAlertDetailPane.m:195
F	dead store in  BGEmoticonMenuPlugin.m:307
Y	dead store in  NSCalendarDate+ISO8601Parsing.m:236
	dead store in  AIEditStateWindowController.m:514
	dead store in  ESOTRUnknownFingerprintController.m:103
	dead store in  sha1.c:104
	dead store in  sha1.c:104
	dead store in  RAFBlockEditorWindowController.m:521
	dead store in  sha1.c:165
	dead store in  sha1.c:104
	dead store in  PTHotKeyCenter.m:105
	dead store in  RBSplitView.m:1652
	dead store in  AWEzvXMLStream.m:129
	dead store in  GBFireImporter.m:627
	dead store in  IconFamily.m:1124
	dead store in  RAFBlockEditorWindowController.m:855
	dead store in  sha1.c:104
	dead store in  fribidi.c:737
	dead store in  sha1.c:165
	dead store in  ESTextAndButtonsWindowController.m:387
	dead store in  AIListGroupCell.m:214
Y	dead store in  AIStatusGroup.m:192	(repeat of  this)  Not 100% certain if this is merely dead code, or a hidden bug. Will look again later.
	dead store in  SLPurpleCocoaAdapter.m:155
	dead store in  ssl-cdsa.c:200
	dead store in  AIAttributedStringAdditions.m:205
	missing -dealloc in  ESSendMessageContactAlertPlugin.m:40
	missing -dealloc in  AIFacebookBuddyListManager.m:19
	missing -dealloc in  AIStatusIconPreviewController.m:19
	missing -dealloc in  AINudgeBuzzHandlerPlugin.m:62
	missing -dealloc in  ESUserIconHandlingPlugin.m:59
	missing -dealloc in  CBStatusMenuItemPlugin.m:26
	missing -dealloc in  ESFileWrapperExtension.m:10
	missing -dealloc in  ESAnnouncerPlugin.m:41
	missing -dealloc in  AIFlexibleToolbarItem.m:11
	missing -dealloc in  DCInviteToChatPlugin.m:37
	missing -dealloc in  AIAdium.m:75
	missing -dealloc in  AIContactListNameButton.m:12
	missing -dealloc in  adiumPurpleEventloop.m:69
	missing -dealloc in  AIWebKitMessageViewPlugin.m:37
	missing -dealloc in  CBContactCountingDisplayPlugin.m:51
	missing -dealloc in  ESDebugWindowController.m:25
	missing -dealloc in  AIToolbarController.m:19
	missing -dealloc in  AIDockController.m:50
	missing -dealloc in  AIStatusChangedMessagesPlugin.m:39
	missing -dealloc in  AITextFieldWithDraggingDelegate.m:16
	missing -dealloc in  AIAccount.m:119
	missing -dealloc in  AISoundController.m:21
	missing -dealloc in  ESApplescriptabilityController.m:31
	missing -dealloc in  SRValidator.m:17
	missing -dealloc in  InstantMessage.m:12
	missing -dealloc in  AIVideoConf.m:24
	missing -dealloc in  adiumPurpleDnsRequest.m:30
	missing -dealloc in  AIAddBookmarkPlugin.m:24
	missing -dealloc in  AIDockBadger.m:41
	missing -dealloc in  AIEmoticonPreferences.m:44
	missing -dealloc in  AIServersideUserIconSource.m:14
	missing -dealloc in  CBPurpleServicePlugin.m:26
	missing -dealloc in  ESWebKitMessageViewPreferences.m:68
	missing -dealloc in  AIFacebookIncomingMessageManager.m:23
	missing -dealloc in  AIDockUnviewedContentPlugin.m:35
	missing -dealloc in  AIVideoConf.m:76
	missing -dealloc in  ESAccountEvents.m:29
	missing -dealloc in  AIStateMenuPlugin.m:41
	missing -dealloc in  AIChatCyclingPlugin.m:37
	missing -dealloc in  AIEmoticonPreviewController.m:21
	missing -dealloc in  AIWindowController.m:35
	missing -dealloc in  AIModularPane.m:19
	missing -dealloc in  AIFloater.m:22
	missing -dealloc in  AIDockIconPreviewController.m:23
	missing -dealloc in  ESWebView.m:28
	missing -dealloc in  AWEzvContact.m:41
	missing -dealloc in  AIContactStatusEventsPlugin.m:37
	missing -dealloc in  AIEmoticonController.m:64
	missing -dealloc in  AIExtendedStatusPlugin.m:42
	missing -dealloc in  AdiumIdleManager.m:33
	missing -dealloc in  LNAboutBoxController.m:38
	missing -dealloc in  ESMSNService.m:24
	missing -dealloc in  AIContactStatusDockOverlaysPlugin.m:50
	missing -dealloc in  Presentity.m:12
	missing -dealloc in  AWRippler.m:134
	missing -dealloc in  DCJoinChatWindowController.m:36
	missing -dealloc in  ESGeneralPreferencesPlugin.m:53
	missing -dealloc in  ESSendMessageAlertDetailPane.m:35
	missing -dealloc in  AIMessageWindowOutgoingScrollView.m:12
	missing -dealloc in  AIMessageWindow.m:22
	missing -dealloc in  AIAdvancedPreferences.m:24
	missing -dealloc in  Buddy.m:12
	missing -dealloc in  AIDualWindowInterfacePlugin.m:30
	missing -dealloc in  GBImportPlugin.m:24
	missing -dealloc in  AIObject.m:27
	missing -dealloc in  SBJSON.m:88
	missing -dealloc in  SetupWizardBackgroundView.m:12
	missing -dealloc in  OWSpellingPerContactPlugin.m:30
	missing -dealloc in  ESPresetNameSheetController.m:18
	null dereference in  AHLinkLexer.yy.c:5005
F	null dereference in  AIWiredString.m:345	(repeat of  this, -11 lines)
	null dereference in  getopt.c:931
	null dereference in  fribidi.c:1160
	null dereference in  fribidi.c:679
	null dereference in  AHLinkLexer.yy.c:5057
	null dereference in  AHLinkLexer.yy.c:4795
	null dereference in  fribidi.c:1368
	null dereference in  AHLinkLexer.yy.c:5055
	null dereference in  AHLinkLexer.yy.c:4515
	null dereference in  AHLinkLexer.yy.c:5066

False Positive Graveyard

This table has been automatically generated from reports that were marked as false positives since the last run, but were not reported in the latest generation. It could mean that they were not correctly merged (for instance, if a line number shifted too much), or a change to Clang removed the false positive altogether.

	Data	Comment
N	memory leak in  DCMessageContextDisplayPlugin.m:444	'Autorelease pool' is tracked in the context dictionary and released correctly (code now cleaner, false positive removed)
N	memory leak in  AIHostReachabilityMonitor.m:790	Previously called a wrapper for CFRelease(); now calls CFRelease() directly
N	memory leak in  AIHostReachabilityMonitor.m:801	Previously called a wrapper for CFRelease(); now calls CFRelease() directly
N	memory leak in  DCMessageContextDisplayPlugin.m:322	'Autorelease pool' is tracked in the context dictionary and released correctly (code now cleaner, false positive removed)
N	memory leak in  AIAbstractLogViewerWindowController.m:1196	The tableview still references it
N	memory leak in  ESGlobalEventsPreferences.m:374	The plugin saves a reference to it
N	memory leak in  AIImageTextCell.m:438	It's not detecting that the if with the release and the if with the alloc have the same condition, and nothing modifies it in between
N	memory leak in  AsyncSocket.m:1388	The only case in which the CFRelease isn't hit is when both objects in question are NULL
N	memory leak in  AsyncSocket.m:1388	The only case in which the CFRelease isn't hit is when both objects in question are NULL
N	dead store in  AIInterfaceController.m:1672
N	missing -dealloc in  AMPurpleJabberFormGenerator.m:134	Doesn't need one, so why bother.