Adium

Ticket #9989 (closed defect: fixed)

Opened 22 months ago

Last modified 11 months ago

Chat log viewer wrongly parses non-emoticon text as emoticons

Reported by: pi++ Owned by: earthmkii
Milestone: Component: Logging
Version: 1.3svn Severity: regression
Keywords: log chat viewer emoticons Cc:
Patch Status:

Description

I've noticed that with svn-revision 23835, when opening the Chat log viewer:
1) The first timestamp, if it contains text that is an emoticon equivalent (things like :1, :0, :2), is shown with an emoticon inside it. That seems to happen only for the minutes (hh:Mm:ss), never for the seconds.

2) Sometimes emoticons are displayed in timestamps following status messages like "State changed to 'offline' (hh:mm:ss)". It happens only sometimes, not always... I can't understand the pattern behind it.

3) What I think is a default ICQ emoticon ( O:-) ) is rendered as a sequence of two emoticons ( :O :-) ) when placed like this ( (hh:mm:ss) NickName:O:-) )

See you,
Pietro

Attachments

Caso 1 - Orario di inizio.png (16.2 KB) - added by pi++ 22 months ago.
Case 1 - First timestamp
Caso 2 - Messaggio di stato.png (8.9 KB) - added by pi++ 22 months ago.
Case 2 - State change message
Caso 3a - Emoticon ICQ visualizzata.png (3.6 KB) - added by pi++ 22 months ago.
Case 3a - ICQ Emoticon
Caso 3b - Emoticon ICQ testo.png (3.1 KB) - added by pi++ 22 months ago.
Case 3b - ICQ Emoticon (as text)

Change History

Changed 22 months ago by pi++

Case 1 - First timestamp

Changed 22 months ago by pi++

Case 2 - State change message

Changed 22 months ago by pi++

Case 3a - ICQ Emoticon

Changed 22 months ago by pi++

Case 3b - ICQ Emoticon (as text)

Changed 22 months ago by jas8522

  • owner changed from nobody to earthmkii
  • severity changed from normal to minor
  • milestone set to Adium X 1.3.x

Changed 22 months ago by Robby

  • severity changed from minor to regression
  • milestone changed from Adium X 1.3.x to Adium X 1.3

Shouldn't this be considered a regression?

Changed 22 months ago by zacw

(In [23848]) Making the Default emoticon set a bit more conservative. Refs #9989.

Changed 22 months ago by zacw

(In [23849]) ':l' too. Refs #9989.

Changed 22 months ago by evands

  • status changed from new to closed
  • resolution set to fixed

(In [23850]) Decode messages separately, and filter them on their own, rather than decoding and filtering the entire displayed chat log. This lets us not emoticonify and otherwise modify timestamps, sender names, and statuses. Fixes #9989

Changed 22 months ago by Robby

  • milestone changed from Adium X 1.3 to SVN issues

Changed 11 months ago by anonymous

  • milestone SVN issues deleted

Milestone SVN issues deleted

Note: See TracTickets for help on using tickets.