Crash when selecting "Undo Typing" or "Redo Typing" after closing a conversation tab

[4ndy]

After typing text into a conversation tab, if the tab is then closed, the "Undo Typing" option (or "Redo Typing" if "Undo Typing" action has been performed) is still available. If selected, or if the hotkey (command-z) is used, Adium will crash.

Note: The"Undo" option is not available if the last tab (and therefore the window) has been closed.

Using Adium 1.2.3, OS X 10.4.11, AOL Instant Messenger account.

[Robby]

I can reproduce this in 1.2.3.

[Robby]

and in 1.3svn, also.

[jas8522]

We've got enough for 1.2.4 already, and this is not a regression - it's been around for a while, so no need to hold up an imminent release for it.

[evands]

Yup, but it offended my tired sensibilities ;)

[evands]

(In [22966]) Each message view controller now provides a unique undo manager to its message entry text view. If we don't do this, we end up with a single undo manager for the whole window per the documentation on the undo manager hierarchy.

This fixes a number of obscure undo/redo bugs in the message window, including crashes after closing a tab and invoking undo/redo (fixes #9511) and undo/redo working across multiple tabs (only one of which is visible) which was just weird.

[evands]

(In [22967]) Merged [22966]: Each message view controller now provides a unique undo manager to its message entry text view. If we don't do this, we end up with a single undo manager for the whole window per the documentation on the undo manager hierarchy.

This fixes a number of obscure undo/redo bugs in the message window, including crashes after closing a tab and invoking undo/redo (fixes #9511) and undo/redo working across multiple tabs (only one of which is visible) which was just weird.