Adium

Ticket #9335 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Bookmark chat allows bookmarking of single user conversations

Reported by: chckens Owned by: evands
Milestone: Adium 1.2.5 Component: Adium UI
Version: 1.2.3 Severity: normal
Keywords: Cc:
Patch Status:

Description

If I click the "bookmark the current chat" toolbar button in an ordinary conversation window on my Jabber account (i.e. with a single other participant rather than an MUC room), a useless entry gets added to my contact list, i.e. double clicking on this new bookmark does nothing.

(Makes me wonder why there are separate toolbar buttons for Add Contact and Add Bookmark... shouldn't a single "Add to Contact List" suffice for both situations?)

Change History

Changed 2 years ago by jas8522

  • milestone set to Adium X 1.2.5

Good point... it should probably only work when there is more than one other person in the chat. Can we grey the button out unless the active tab is a MUC?

Changed 2 years ago by jas8522

  • summary changed from bookmark chat button "works" when it shouldn't to Bookmark chat allows bookmarking of single user conversations

Changed 2 years ago by evands

  • owner changed from nobody to evands
  • status changed from new to assigned

You might want to add another contact (say, one that your friend just told you about) using Add Contact, though I'm not sure that's a strong enough reason not to combine the buttons into one. In any case, the bug itself is simple here :)

Changed 2 years ago by evands

  • status changed from assigned to closed
  • resolution set to fixed

(In [23055]) Only enable the bookmark toolbar item if we're in a group chat. Fixes #9335

Changed 2 years ago by evands

(In [23056]) merged [23055]: Only enable the bookmark toolbar item if we're in a group chat. Fixes #9335

Note: See TracTickets for help on using tickets.