Ticket #7769 (closed defect)
Shadow behind transparent chat window isn't updated
| Reported by: | yorn | Owned by: | nobody |
|---|---|---|---|
| Milestone: | Component: | Adium UI | |
| Version: | Severity: | normal | |
| Keywords: | Cc: | ||
| Patch Status: |
Description
I installed Safari 3 beta, got hit by #7164 so I compiled from SVN (since the bug is already fixed there). Now it occured to me that transparency works fine now, but the shadow isn't updated at message sending or retrieval. Forcing the shadow to be repainted (by resizing the window or taking it's focus) fixes the problem, but it occurs again when a new message is sent/received. You can see this effect on the attached screenshot; See the message "whoa this message is ghosted! :o", a few pixels below you see the same message "ghosting". This happend because the text was there before the message "I bet this should not happen" appeared and moved it up. The "ghosting" happens to both text and images.
I believe this can be fixed by forcing the shadow to be repainted everytime something changes in the message area
Attachments
Change History
Changed 4 years ago by yorn
-
attachment
Screenshot.png
added
comment:1 Changed 4 years ago by ccsccs7
Ahh. It's a little hard to see if your LCD screen brightness isn't turned up high enough.
comment:3 Changed 4 years ago by catfish_man
- Status changed from new to closed
- Resolution set to fixed
(In [20840]) Invalidate the window shadow when using a transparent background. Fixes #7769
comment:6 in reply to: ↑ description Changed 4 years ago by yorn
Well sorry, the bug isn't entirely fixed, shadow is updated after sending/receiving messages, but not after changing the tab..
comment:7 Changed 4 years ago by Catfish_Man
- Status changed from closed to reopened
- Resolution fixed deleted
- Milestone changed from Adium X 1.1.2 to Adium X 1.1.3
comment:9 Changed 4 years ago by yorn
I just figured that the shadow also isn't updated after scrolling, and when typing very long messages (the input box gets higher, thus moving the text up, but not the shadow)
comment:10 Changed 4 years ago by cbarrett
It's kind of ridiculous that we have to invalidate the shadow ourselves. "Perf win" for webkit? Perhaps. Annoying for us? Definitely.
comment:11 Changed 4 years ago by evands
The old solution overrode drawRect: and invalidated it; this was effective. It appears WebKit is no longer calling drawRect to draw a WebView :P A perusal of the source should be able to indicate the appropriate method to override.
comment:12 Changed 4 years ago by evands
I can't figure out how WebView draws based on the source code.
comment:13 Changed 4 years ago by cbarrett
If they're not using drawRect, they are probably just drawing "directly" to the CGContext for that view.
We should file a bug with Apple -- they should at least be calling the drawRect: for their WebView, even if their implementation does nothing.
comment:14 Changed 4 years ago by evands
- Milestone changed from Adium X 1.1.3 to Waiting on Apple
Would somebody please file a bug with the webkit team on this issue? I believe David talked with someone about it; a link to the ticket would be nice if one exists.
comment:15 Changed 4 years ago by djmori
comment:16 Changed 3 years ago by zacw
- Status changed from new to closed
Closing all waiting on apple tickets. These just take up space, and are largely ignored anyway. Any functionality we need but cannot add due to apple is a good radar to file, but we are not apple's tracker.
comment:17 Changed 3 years ago by anonymous
- Milestone Waiting on Apple deleted
Milestone Waiting on Apple deleted


The ghosting effect in action