Emoticons don't correctly re-display after installing Safari 3

[Nebula]

I installed the Safari 3 Public Beta today. Emoticons show correctly initially. When you click the emoticon to show the text used to create it, the text is correctly displayed. However, clicking again to restore the emoticon instead shows the blue question mark placeholder graphic.

[Nebula]

Example

[marcushe]

I can confirm this problem and resolution as well.

[roggnroll]

Confirmed. Got the same problem! roggnroll

[jas8522]

Yep definitely an issue.

[Zeros]

The issue seems to relate to changes in how random attributes are handled on elements.

The broken adium feature works by setting the attribute 'src' on the anchor to the src of the image using a.setAttribute('src', url); but later accesses it with a.src which return undefined since that attribute doesn't exist.

The fix for this is a one liner in the Webkit Message View plugin:

Adium.app/Contents/PlugIns/WebKit\ Message\ View.AdiumPlugin/Contents/Resources/Template.html:107

			img.setAttribute('src', node.src );

Should be changed to:

			img.setAttribute('src', node.getAttribute('src') );

This fixes the bug and makes the emotes return when you click the text replacement.

It should be noted that all the Template JS and Adium JS in general should be converted to either use direct access with .attr= or setAttribute/getAttribute because how attributes are set changes the rules about how they can be accessed.

[jas8522]

Marking as patch included, however if you can make a diff patch for this and attach it here, it's usually preferred.

[Catfish_Man]

Interesting. I will try this out this evening.

[catfish_man]

(In [20700]) Patch from 'Zeros' on trac to fix clicking on emoticons in Safari 3. Thanks! Fixes #7148

[evands]

(In [20705]) Merged [20700] (catfish_man): Patch from 'Zeros' on trac to fix clicking on emoticons in Safari 3. Thanks! Fixes #7148