Ticket #6541 (closed enhancement: fixed)
Patch to add (some) support for xmpp: URIs
| Reported by: | mdippery | Owned by: | nobody |
|---|---|---|---|
| Milestone: | Adium X 1.1 | Component: | Adium Core |
| Version: | 1.1svn | Severity: | normal |
| Keywords: | jabber, xmpp, URI, link | Cc: | patches@… |
| Patch Status: | Accepted |
Description
This patch relates to discussion in the forum post Auto add new account. It adds some support for xmpp: links, as specified in XEP-0147. The specific additions are:
- An addition to AIURLAdditions that parses the query component of xmpp: URIs, which have a slightly different syntax that the URLs already supported in AIURLAddtions. New method is fully documented.
- Adds some support for xmpp: protocol URIs. Currently, I could only get message, roster, and subscribe URIs to work; remove and unsubscribe URIs are non-functional. I'm still working on that support. (To make it a long story, I'm trying to figure out a way to remove contacts as though the user had selected a name in the contact list and removed it through the GUI, so the user is prompted before it is removed.) However, I figured that message, add roster item, and subscribe support was more important and a lot cooler.
Patch is attached.
Attachments
-
xmpp.diff
(4.6 KB) -
added by mdippery 5 years ago.
- Patch file for described enhancements
-
xmpp-new.diff
(4.7 KB) -
added by mdippery 5 years ago.
- New patch: Tweaks AIURLAdditions to work with semicolons or ampersands in query string.
Change History
comment:2 Changed 5 years ago by cbarrett
Michael, I'm wondering if it wouldn't be better to teach queryArgumentsForKey about semicolons? IIRC they are valid as a separator in any url, technically.
I'm kind of surprised that this type of parsing doesn't already exist in NSURL.
comment:3 Changed 5 years ago by mdippery
Wouldn't be a terrible idea. I could look into that and re-submit a patch with that idea in mind.
comment:4 Changed 5 years ago by cbarrett
- field_haspatch changed from 1 to 0
That'd be awesome, thanks a lot :)
recheck Patch included when you post a new patch.
comment:5 Changed 5 years ago by mdippery
- Cc patches@… added; feedback@… removed
- field_haspatch changed from 0 to 1
Tweaked the patch so that -[NSURL(AIURLAdditions) queryArgumentForKey:] can now deal with semicolons or ampersands in the query string.
Changed 5 years ago by mdippery
-
attachment
xmpp-new.diff
added
New patch: Tweaks AIURLAdditions to work with semicolons or ampersands in query string.
comment:9 in reply to: ↑ 6 Changed 5 years ago by evands
Does the new patch supersede the previous one, or are both intended to be applied?
comment:10 Changed 5 years ago by mdippery
New patch supersedes old, only the new patch should be applied.
comment:11 Changed 5 years ago by evands
- Status changed from new to closed
- Resolution set to fixed
comment:12 Changed 4 years ago by Robby
- Patch Status changed from Needs Dev Review to Accepted
- pending set to 0
Patch file for described enhancements