Adium

Ticket #4161 (closed defect: fixed)

Opened 4 years ago

Last modified 23 months ago

Empty Jabber message body is displayed incorrectly

Reported by: delta407@lerfjhax.com Owned by: am
Milestone: Adium 1.2.5 Component: Service/Jabber (XMPP)
Version: 1.2.4b2 Severity: minor
Keywords: Cc:
Patch Status:

Description

Summary: Adium incorrectly displays a message conaining "<body/>" when an empty message is received. This may affect only empty-element tags -- that is, <body/> and not <body></body> -- however, both forms are defined to be equivalent.

Steps to reproduce: 1. Use Adium to connect to a Jabber server. 2. Have another Jabber user transmit the following:

<message xmlns='jabber:client' from='user@domain/resource' to='tester@domain/Adium'><body/></message>

Expected behavior: An empty message is displayed, visually identical to receipt of a message containing "<body> </body>".

Actual behavior: A message is displayed, visually identical to receipt of a message containing "<body>&lt;body/&gt;</body>".

Change History

Changed 4 years ago by edr1084

  • milestone set to Sometime after 1.0

Changed 4 years ago by am

  • status changed from new to closed
  • resolution set to fixed

Doesn't occur in the Smack-based plugin, since it actually uses a proper XML parser.

Changed 3 years ago by arjenvr

This behaviour returned when Smack was dropped.

Changed 3 years ago by edr1084

  • status changed from closed to reopened
  • patch_status set to None
  • resolution fixed deleted
  • version changed from 0.89 to 1.1svn
  • milestone changed from Good idea for "later" to Summer of Code 07

Changed 2 years ago by jas8522

  • pending set to 1
  • milestone changed from Summer of Code 07 to Needs feedback from users

Does this still happen with 1.2.3 or the 1.2.4 AdiumBeta?

Changed 2 years ago by arjenvr

Able to reproduce this in 1.2.3. Adium displays '<body/>' when sending either an empty body tag (<body></body>) or a self-closing body tag (<body />).

Changed 2 years ago by jas8522

  • version changed from 1.1svn to 1.2.3

Any change with 1.2.4b2? (AdiumBeta)

The libpurple update might be parsing this differently now - which is why I ask.

Changed 2 years ago by arjenvr

Still happens with 1.2.4b2

Changed 2 years ago by jas8522

  • owner changed from nobody to am
  • status changed from reopened to new
  • version changed from 1.2.3 to 1.2.4b2
  • pending changed from 1 to 0
  • milestone changed from Needs feedback from users to Adium X 1.2.5

Changed 23 months ago by evands

  • status changed from new to closed
  • resolution set to fixed

(In [23210]) Ignore /BODY tags when decoding HTML. Fixes #4161

Changed 23 months ago by evands

(In [23211]) Merged [23210]: Ignore /BODY tags when decoding HTML. Fixes #4161

Note: See TracTickets for help on using tickets.