Adium

Ticket #3980 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Upgrade code for new xtras/removed xtras

Reported by: tick Owned by: Catfish_Man
Milestone: Adium X 1.0 Component: Xtras
Version: Severity: major
Keywords: Cc:
Patch Status:

Description (last modified by durin42) (diff)

We need to upgrade existing installations of new stuff, and if a message style was removed we need to gracefully change to something else.

List here the needed changes:

Plastic -> Stockholm Aqua icon set -> pss2 icon set (double-check - it hasn't worked for me with any sense of reliability if it's there)

Change History

comment:1 Changed 6 years ago by tick

  • Milestone set to Adium X 1.0 Beta

comment:2 Changed 6 years ago by evands

  • Description modified (diff)

comment:3 Changed 6 years ago by tick

  • Owner changed from nobody to Catfish_Man

comment:4 Changed 6 years ago by catfish_man

(In [15997]) Starts of an 'xtra not found' notification system. Refs #3980

comment:5 Changed 6 years ago by evands

So a user launches 1.0 and is presented with an error?

Perhaps we should just do a silent upgrade...

comment:6 Changed 6 years ago by boredzo

There ought to be such a system anyway, even with the ability to migrate an old Xtra choice to a new one.

comment:7 Changed 6 years ago by catfish_man

Yeah, in retrospect, perhaps presenting an error dialog is not the greatest idea. We already have some silent upgrade code (switches to the default message style)... how would we let users know what happened though? I don't really feel like getting flooded with "1.0 broke my messages !!!" when we release.

comment:8 Changed 6 years ago by tick

We've done the silent upgrades/fallbacks a long time ago, it was mostly acceptable.

comment:9 Changed 6 years ago by catfish_man

  • Status changed from new to closed
  • Resolution set to worksforme
  • Milestone Adium X 1.0 Beta deleted

worksforme based on comments and existing behavior.

comment:10 Changed 6 years ago by evands

  • priority changed from normal to high
  • Status changed from closed to reopened
  • Resolution worksforme deleted
  • Severity changed from normal to blocker
  • Milestone set to Adium X 1.0 Beta

Silent upgrade needs to actually be implemented, though.

comment:11 Changed 6 years ago by evands

In other words, if the person was using Plastic, it should switch to Stockholm, which is similar. Minimal should switch to Minimal Mod.

comment:12 Changed 6 years ago by durin42

  • Description modified (diff)

comment:13 Changed 6 years ago by evands

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [16472]) Smart upgrading of the message styles we removed from 0.8x to the appropiate styles in 1.0. Closes #3980

comment:14 Changed 6 years ago by tick

  • Milestone changed from Adium X 1.0 Beta to Adium X 1.0
Note: See TracTickets for help on using tickets.