Adium

Ticket #2463 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

rate limited after changing songs willy nilly

Reported by: anonymous Owned by: eharris
Milestone: Adium X 1.0.2 Component: None
Version: 1.0b17 Severity: minor
Keywords: rate limiting, iTunes, changing songs quickly Cc: jmpp@…
Patch Status:

Description

if status is set to "Current iTunes Track" Adium rate limits after skipping over a couple of songs

Change History

  Changed 4 years ago by tick

  • milestone set to SVN issues

Ya, this is a server side thing with AIM, if you change your song it will update on the server. Talk to the server too often, and viola, no more mr nice aim server.

Maybe we could update the server after the user stops selecting?

  Changed 4 years ago by tick

  • summary changed from rate limit to rate limited after changing songs willy nilly

  Changed 4 years ago by evands

  • keywords fixedByJoscar added

joscar automanages rate limiting.

  Changed 4 years ago by catfish_man

  • milestone SVN issues deleted

de-milestoning fixedByJoscar

  Changed 4 years ago by durin42

  • status changed from new to closed
  • resolution set to fixed

(In [15524]) Merge joscar to trunk, causing much rejoicing. Fixes #2377. Fixes #2488. Fixes #2463. Fixes #2413. Fixes #2231. Fixes #2230. Fixes #4. Fixes #2903.

follow-up: ↓ 7   Changed 3 years ago by ibiwan

  • status changed from closed to reopened
  • resolution fixed deleted

In 1.0b15, Oct 29 Build, I'm getting the originally-described behavior when skipping through several songs at a time in iTunes.

in reply to: ↑ 6   Changed 3 years ago by edr1084

Replying to ibiwan:

In 1.0b15, Oct 29 Build, I'm getting the originally-described behavior when skipping through several songs at a time in iTunes.

The "official" b15 is Nov 11, try downloading from the beta page just to make sure the additional changes don't cause a different result.

  Changed 3 years ago by fwenzel

confirming the bug for b15. Still occurs after clicking through a few songs in iTunes.

  Changed 3 years ago by jmpp

  • cc jmpp@… added
  • keywords rate limiting, iTunes, changing songs quickly added; fixedByJoscar removed
  • version changed from 1.0svn to 1.0b17

Adium moved back to libgaim for AIM connectivity after b15, so I'm deleting joscar references in this ticket's details as appropriate. I'm experiencing this exact same error with b17, AIM servers complain with rate limiting errors if I skip two or three songs a tad too quickly ( %_iTunes is my status message script... I suppose it also happens with %_music). After that, more errors keep pouring in until I stop, without disconnecting me though.

-jmpp

  Changed 3 years ago by Robby

Bug still exists in b15, too, by the way.

  Changed 3 years ago by jmpp

"Last action you attempted could not be performed because you are over the rate limit. Please wait 10 seconds" is the exact error I'm seeing, and just now I confirmed that if I change the songs one too many times AIM servers do disconnect me ;-)

-jmpp

follow-up: ↓ 13   Changed 3 years ago by cavemoneky50

Just noting, this is still an issue for me and is present in current beta builds.

in reply to: ↑ 12   Changed 3 years ago by julian

While this bug still drives me somewhat nuts and I agree with tick's idea of updating the server *after* the user has finished selecting songs, you can work around it by pausing iTunes before skipping through songs.

follow-up: ↓ 15   Changed 3 years ago by pilgrim

This is happening to me right now with 1.0.

Also, and this might not be a bug, but I can't seem to disable the itunes functionality. So now skipping songs always gives me that annoying window. Should a new ticket be opened for this?

in reply to: ↑ 14   Changed 3 years ago by julian

Replying to pilgrim:

This is happening to me right now with 1.0. Also, and this might not be a bug, but I can't seem to disable the itunes functionality. So now skipping songs always gives me that annoying window. Should a new ticket be opened for this?

Have you tried clicking the Status menu, then selecting a status other than the iTunes one?

  Changed 3 years ago by StoneTable

Pausing iTunes before skipping songs does not work. I still get the rate limit error, using 1.0.1. The only work-around seems to be to change the status to not iTunes, change songs in iTunes, and then change the status back to iTunes.

From the looks of the error, there needs to be 10 seconds between status message updates.

  Changed 3 years ago by evands

  • milestone set to Adium X 1.0.2

This indicates a bug in the oscar rate limiting code in libgaim... but should also be easy to suppress via throttling within Adium, much as we already do for MSN display names.

  Changed 3 years ago by eharris

  • owner changed from nobody to eharris
  • status changed from reopened to new

  Changed 3 years ago by eharris

  • status changed from new to assigned

This is fixed. I've decided on a time limit of 3 seconds. Once the song has played for three seconds, your status will be updated. Committing once I stop leaking somewhere.

follow-up: ↓ 21   Changed 3 years ago by eharris

  • status changed from assigned to closed
  • resolution set to fixed

(In [19087]) Fixes #2463

in reply to: ↑ 20   Changed 3 years ago by menesis

  • patch_status set to None

Thank you very much! :)

  Changed 3 years ago by zacw

  • priority changed from highest to low
  • component changed from MSN to None
  • severity changed from blocker to minor
  • milestone changed from Adium X 1.0.3 to Adium X 1.0.2
Note: See TracTickets for help on using tickets.