jabber group chat history missing messages from self

[ttimo@idsoftware.com]

If you join a jabber group chat that is configured to keep and display recent chat history in the channel, with Adium you get the history of others talking in the group chat, but not your own. For instance if you had a conversation with someone else, all you'll see is the other guy talking in the history log on reconnect.

[evands]

I'm fairly sure we have no way of distinguishing history messages from non-history... and we suppress messages from self to prevent them from being displayed twice when you send. However, Gaim doesn't duplicate messages as far as I'm aware, so perhaps we should reevaluate how this is implemented.

[ttimo@…]

When using gaim in the same situation, it only prints self messages when they come back from the server. That is an easy way to tell if you are still connected properly .. if you keep typing and nothing appears back .. something is wrong. ( well, and history printout on join works too )

[aeon@…]

This is an annoying issue with our internal Jabber server. What I say during the conversation is important if I need to go back and see the flow of the dialogue. I need to be able to see what I said.

[simon@…]

Fix for missing history display

[simon@…]

I think the fix for this is fairly straightforward. The attached change to adiumGaimConversation.m solves this issue for me, although I haven't tested it with non-Jabber protocols.

[simon@…]

That earlier fix was inadequate. However, further investigation reveals that gaim sets a per message flag GAIM_MESSAGE_DELAYED on all of the messages which are establishing group chat history. These are the only messages which this flag is set for. By conditionalising the GAIM_MESSAGE_SENT checks, it is possible to get Jabber chatroom history, without causing any duplicate messages to appear.

I've got a patch locally, but it will take some untangling from my tree (I've got code to enable GSSAPI support in there, too). If the patch would be useful, and likely to be applied, let me know and I'll dig it out.

Simon.

[evands]

Sure, that sounds like a good solution and I'd be happy to apply the patch.

[evands]

With the changed pointed out, it's easy enough to do locally. adiumGaimConversation.m:75, right?

if (!who || (flags & GAIM_MESSAGE_DELAYED) || strcmp(who, gaim_conv_chat_get_nick(GAIM_CONV_CHAT(conv)))) {

[evands]

(In [16179]) Fix from simon@… to display Jabber message history in group chats properly even when you were the one who sent it originally. Fixes #1881

[simon@…]

Working patch, but needs some further work before committing.

[simon@…]

Did you test that fix - I think that a bit more than that is required. In particular, if GAIM_MESSAGE_SEND is set (which it will be, as GAIM_MESSAGE_DELAYED only occurs with GAIM_MESSAGE_SEND), that section of code will never be reached.

I've attached the fix that I'm running with at the moment. Note that this isn't ideal - as I just comment out some of the duplicate checks, rather than special casing them - it should give you an idea where to look, though. I'm away for the next two weeks, but if you haven't had a chance to look at it before then, I'll try and do a proper fix upon my return.

Simon.

[evands]

(In [16280]) Changes based on a patch from simon@… which should properly fix #1881: jabber group chat history missing messages from self. Fixes #1881.

[isaac@…]

This still does not work for me with the latest beta - possibly a regression (not that I've ever seen it fixed, and I've used every release since the .70's days) from when this was fixed?

Feel free to test on our jabber server - the chat swat@… is open to the public, and will display the behaviour. Works fine in gaim on the same server.

[evands]

This works fine for me in 1.0b9 (and that code hasn't changed since 1.0b1). isaac, are you sure you were using a 1.0 beta when your test failed?

[evands]

Ah. If you have a handle set, it works. If you don't, it fails.

[evands]

(In [17418]) Removed unneeded 'double checks' against messages sent from self... which were messing up display of history messages in Jabber (and other) group chats. Fixes #1881 for real.