Adium

Ticket #1442 (closed enhancement: fixed)

Opened 7 years ago

Last modified 7 years ago

Remove "Play through device" pref

Reported by: catfish_man Owned by: nobody
Milestone: Adium X 1.0 Component: Adium UI
Version: 0.84 Severity: normal
Keywords: Cc:
Patch Status:

Description

This pref is taking up space, and is both confusing and rarely used. It should go the way of the dodo.

Change History

comment:1 Changed 7 years ago by catfish_man

  • Status changed from new to closed
  • Resolution set to fixed

(In [13493]) Removing output device pref. Fixes #1442

comment:2 Changed 7 years ago by evands

(In [13498]) Changes needed for [13493] (Refs #1442):

  • Added AILocalizedString(@"Sound",nil), AILocalizedString(@"Play through default device",nil) and AILocalizedString(@"Play through alert device",nil) to DeadStrings.h; when a string is removed from HEAD but not from adium-0.8, so long as we're continued .8x development, it should be added to that file so genstrings continues to include it in the Localizable.strings files.
  • Sound now always plays through the alert device (rather than playing through whichever device you selected last in the now-removed preference)
  • ESGeneralPreferences compiles again
Note: See TracTickets for help on using tickets.