Adium spams Console

[Robby]

Every now and then, Adium spams the Console multiple times per second with the following line:

08.11.09 04:04:01 Adium[489] +[NSColor(AIColorAdditions) colorWithHTMLString:] called with unrecognised color name (str is &#x23); returning NSCalibratedWhiteColorSpace 0 1 

This is not happening persistently. However, I haven't been able to connect it to any specific action in Adium.

[wbowling]

This happens for me when browsing though pretty much any xml chat log in the transcript viewer.

I think it happens because in AIXMLChatlogConverter with any 'style="color: #000000;...' the '#' gets converted to "#". When the colour is being read in AIHTMLDecoder.m:1589 by the following line:

while([styleScanner scanUpToString:@";" intoString:&style])

it only reads up to the first ';', so the colour code ends up being "&#x23" which is invalid.

[Robby]

Thanks, William, for looking into this.

Replying to wbowling:

This happens for me when browsing though pretty much any xml chat log in the transcript viewer. <snip>

Confirmed.

[cbarrett]

I'm going to try to reproduce this. If I can, I'll take a stab at fixing it.

If someone else is working on it, LMK.

[Zachary West <zacw@…>]

(In  ba94093fbed8) At some point in time, the need to replace &amp; with & to allow linking to work died off. Do not try to mess with the URL at all. Fixes #13382.

Because &amp; was being replaced with &, any following # were considered part of a &#…; sequence, which was causing some serious misparsing. By removing both the &amp;->& and #->&#x23;, we kill two birds with one stone.