Adium

Ticket #13356 (closed enhancement: fixed)

Opened 4 months ago

Last modified 4 months ago

Please make focus class apply to all new messages after focus is lost

Reported by: mathuaerknedam Owned by:
Milestone: Adium 1.4 Component: Message View
Version: 1.4b14 Severity: normal
Keywords: Cc:
Patch Status:

Description (last modified by mathuaerknedam) (diff)

Please make focus class apply to all new messages after focus is lost, including status/event messages.

The current behavior (affecting only the first unfocused message) would still be achievable with css selection. The proposed change would allow plying "unfocus" styling to all new messages, which is otherwise difficult to achieve. styling all new messages can be useful to clue users in to the loss of focus and newness of messages when the first unfocused message has scrolled outside of the window. there is still a mark in the scrollbar, but if the scrollback is large the scrollbar focus mark can easily be behind the scrollbar thumbwheel.

Change History

Changed 4 months ago by mathuaerknedam

  • description modified (diff)
  • summary changed from Please make focus class apply to new messages after focus is lost to Please make focus class apply to all new messages after focus is lost

Changed 4 months ago by Zachary West <zacw@…>

  • status changed from new to closed
  • resolution set to fixed

(In  df722b0497ca) Set the focus element for all elements when out of focus. Fixes #13356.

This also fixes setting the mark location correctly, as well as sets the first non-focused message as having class "firstFocus".

Changed 4 months ago by mathuaerknedam

Cool, thanks.

Two things:

  • Are you intentionally excluding status/event messages? Personally, I'd prefer them to be classed too, it's easy enough for the message style to ignore those if desired. Also, it means that the focus indicator may lie about what happens after focus was lost, since many status messages can display before the focus indicator gets applied to the first non-status message.
  • The messages preview looks funny. I can't "inspect element" to see exactly what's happening, but it appears that every message is classed as "focus" (using SO3).

Changed 4 months ago by mathuaerknedam

  • status changed from closed to new
  • resolution fixed deleted
  • milestone set to Adium 1.4

Changed 4 months ago by Zachary West <zacw@…>

(In  67be3e959a78) Don't base focus application on content tracking, since status messages aren't tracked. Base it on whether or not the content is post-processed (i.e., logged). Refs #13356.

Changed 4 months ago by zacw

  • status changed from new to closed
  • resolution set to fixed

The "not in preview chats" is also done with the change, since preview chats set not to post-process content.

Note: See TracTickets for help on using tickets.