Adium

Ticket #13300 (closed enhancement: fixed)

Opened 4 months ago

Last modified 4 months ago

Allowing better focus styling through adding "lostFocus" to %messageClasses%

Reported by: mathuaerknedam Owned by:
Milestone: Adium 1.4 Component: Message View
Version: 1.4b13 Severity: normal
Keywords: Cc:
Patch Status:

Description

There are certain styling limitations with the way focus indicators are currently implemented. For example, #12145 points out how the default focus indicator can obscure message text and the SmoothOp page describes how the focus indicator can overlap the mention indicator. Also, it's difficult to integrate the focus indicator into a message style's "look".

This proposal is that when focus is lost adium would add "lostFocus" to %messageClasses% for the next message. When the next focus change is made Adium would need to find the existing "lostFocus" remove it, and add it to new location. Zac further suggests requiring a message style info.plist key to enable the functionality.

Here's a IRC transcript of Zac's response:

10:13:26 zac ‣ sort of possible yes	
10:15:08 zac ‣ it's a good idea for 1.4.1 but not for 1.4	
10:15:18 zac ‣ we can add an info.plist entry for "supports focus recognition" and do that

Change History

Changed 4 months ago by mathuaerknedam

  • milestone set to Adium 1.4.x

Changed 4 months ago by Zachary West <zacw@…>

  • status changed from new to closed
  • resolution set to fixed

(In  bb4935318350) Instead of inserting a <hr/> when we lose focus, which ends up breaking more than you'd expect, add a message class for the next message. Fixes #13300.

This removes the "Show Focus Lines" preference (always a good thing), and always inserts the mark in the scrollbar. It will be up to the style to implement the "focus" class to show the location. All previous messages of class "focus" will have "focus" removed when focus is lost again.

Changed 4 months ago by Robby

  • milestone changed from Adium 1.4.x to Adium 1.4

Changed 4 months ago by Zachary West <zacw@…>

(In  7ff6b3f336d6) Instead of inserting a <hr/> when we lose focus, which ends up breaking more than you'd expect, add a message class for the next message. Fixes #13300.

This removes the "Show Focus Lines" preference (always a good thing), and always inserts the mark in the scrollbar. It will be up to the style to implement the "focus" class to show the location. All previous messages of class "focus" will have "focus" removed when focus is lost again.

Changed 4 months ago by Zachary West <zacw@…>

(In  2b6390521141) Don't add a focus class for messages in the active chat. Refs #13300.

Changed 4 months ago by Zachary West <zacw@…>

(In  a2f78c3401b9) Don't add a focus class for messages in the active chat. Refs #13300.

Note: See TracTickets for help on using tickets.