Adium

Ticket #13280 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

Menu items for IRC are disabled

Reported by: wbowling Owned by: zacw
Milestone: Component: Service/IRC
Version: 1.5hg Severity: normal
Keywords: IRC Menu Items Cc:
Patch Status: Rejected

Description

Summary

Currently any IRC account action menu items are disable, eg View MOTD from libpurple.

Steps to reproduce

File -> IRC Account -> View MOTD

Expected results

Menu item should be enabled if the account is connected.

Actual results

Menu item is disabled all the time.

Regression

Happens because of  d11404141154 and menu items with no tag specified default to an AIOperationRequirement of AIRequiresHalfop.

Notes

Patch adds AIRequiresNone as the first item in AIOperationRequirement so that when no tag is specified it will get chosen, and adds code to always validate items with tag AIRequiresNone.

Patch:  3c61985387e0

Change History

Changed 5 months ago by zacw

  • patch_status changed from Initially Included to Needs Dev Review
  • milestone set to Adium 1.4

Good find.

Changed 5 months ago by zacw

Good find, wbowling, but the modification needs to be a little more flexible.

Changed 5 months ago by Zachary West <zacw@…>

  • status changed from new to closed
  • resolution set to fixed

(In  70c7d70b49cb) Allow menu items to be validated if they aren't channel operations. Fixes #13280.

Changed 5 months ago by Zachary West <zacw@…>

(In  e47bfb289f64) Allow menu items to be validated if they aren't channel operations. Fixes #13280.

Changed 5 months ago by Robby

  • patch_status changed from Needs Dev Review to Rejected
  • milestone Adium 1.4 deleted
Note: See TracTickets for help on using tickets.