Adium

Ticket #13237 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

Names beginning with [ do not tab complete properly in IRC

Reported by: [ICR] Owned by: zacw
Milestone: Component: Service/IRC
Version: 1.3.7 Severity: normal
Keywords: Cc:
Patch Status:

Description

If someone has a nickname beginning with [ do not tab complete properly in IRC.

Steps to reproduce: 1) Go into an IRC room where someone has a nick beginning with [ (e.g [ICR]) 2) Type [, tab and it tab completes 3) Type [I and it doesn't tab complete properly but instead tries to instead autocomplete words beginning with I.

Change History

in reply to: ↑ description   Changed 5 months ago by [ICR]

Replying to [ICR]:

If someone has a nickname beginning with [ do not tab complete properly in IRC. Steps to reproduce: 1) Go into an IRC room where someone has a nick beginning with [ (e.g [ICR]) 2) Type [, tab and it tab completes 3) Type [I and it doesn't tab complete properly but instead tries to instead autocomplete words beginning with I.

It also doesn't work if there is text before the [.

  Changed 5 months ago by Zachary West <zacw@…>

  • status changed from new to closed
  • resolution set to fixed

(In  e6cf2d4672e5) Control more directly the completion range for group chats. Fixes #13237.

We now go back to the nearest whitespace and see if it would autocomplete any nicks at that point. If it would, we perform the autocompletion starting at that point. If it doesn't, we let the OS do its normal thing.

This fixes autocompleting things like "[mynick]" or the channel name (such as "#adium") since they start with non-word characters, but are perfectly valid.

  Changed 5 months ago by Zachary West <zacw@…>

(In  862f4e3f05e1) Control more directly the completion range for group chats. Fixes #13237.

We now go back to the nearest whitespace and see if it would autocomplete any nicks at that point. If it would, we perform the autocompletion starting at that point. If it doesn't, we let the OS do its normal thing.

This fixes autocompleting things like "[mynick]" or the channel name (such as "#adium") since they start with non-word characters, but are perfectly valid.

Note: See TracTickets for help on using tickets.