Bookmarked IRC status icon doesn't change

[Alien Collective]

When I change status icon sets, all of my icons change except for bookmarked IRC channels. These continue to show the old set's available/online icon until Adium is restarted. However, the status icons on IRC chat tabs and IRC service icons in the contact list change properly.

[Alien Collective]

Just an extra note: I've noticed that it does change properly when the "alert" icon is displayed, and the change sticks after the icon returns to normal. I haven't had a chance to test if the icon changes to the correct set when the alert is displayed if the set change takes place while the icons are normal.

Now that Twitter is  working, the timeline's status icon also seems to be affected in the same way as IRC bookmarks. Twitter contacts look fine, though.

[Alien Collective]

One last update: When the alert status is removed, the icon changes back to its previous (incorrect) state.

[Zachary West <zacw@…>]

(In  791780625051) Include bookmarks in the contact controller's contactDict, so that a -contactEnumerator also contains them. By way of updating properly, fixes #13221.

We weren't providing LO updates to observers when updating all contacts, since the enumerator was being used. This also removes a bookmark-specific iterator when using the enumerator is now sufficient.

[Zachary West <zacw@…>]

(In  9b757472094b) Include bookmarks in the contact controller's contactDict, so that a -contactEnumerator also contains them. By way of updating properly, fixes #13221.

We weren't providing LO updates to observers when updating all contacts, since the enumerator was being used. This also removes a bookmark-specific iterator when using the enumerator is now sufficient.

[zacw]

Bookmarks were present in 1.3.

[Robby]

True

[wixardy]

Ticket #12917 has been marked as a duplicate of this ticket.

[Zachary West <zacw@…>]

(In  b820c57cac38) Backed out changeset 791780625051

This is causing regressions in a few other locations. Backing out for the next beta to investigate after. Refs #13221.

[Zachary West <zacw@…>]

(In  8983d9241c62) Backed out changeset 791780625051

This is causing regressions in a few other locations. Backing out for the next beta to investigate after. Refs #13221.