Adium

Ticket #13097 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Chat transcripts deleted

Reported by: assetburned Owned by:
Milestone: Adium 1.4 Component: Adium UI
Version: 1.4b9 Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description

Simply pressing the backspace key shouldn't delete a log. there should be a message for confirmation!

Attachments

wildwobby-13097-101109.diff Download (972 bytes) - added by wildwobby 3 years ago.
Patch will ask for confirmation when deleting with the backspace button using the already instate confirmation methods.
addition-13097-102809.diff Download (1.6 KB) - added by wbowling 3 years ago.
Patch to stop confirmation or try to deletion of 0 selected logs
addition-13097-102809-v2.diff Download (1.6 KB) - added by wbowling 3 years ago.
Uses == 1 istead of != 0

Change History

Changed 3 years ago by wildwobby

Patch will ask for confirmation when deleting with the backspace button using the already instate confirmation methods.

comment:1 Changed 3 years ago by Robby

  • Patch Status set to Needs Dev Review
  • Milestone set to Adium 1.4

Go, Robby! :)

comment:2 Changed 3 years ago by Robby 

23:29:40 kbotc: #13097 looks pretty good to me..

comment:3 Changed 3 years ago by Zachary West <zacw@…>

  • Status changed from new to closed
  • Resolution set to fixed

(In  3d815231bb66) Patch from wildwobby which confirms before removing logs when hitting the delete key. Fixes #13097.

comment:4 Changed 3 years ago by Robby

  • Patch Status changed from Needs Dev Review to Accepted

comment:5 Changed 3 years ago by Zachary West <zacw@…>

(In  ff31212ab05e) Patch from wildwobby which confirms before removing logs when hitting the delete key. Fixes #13097.

Changed 3 years ago by wbowling

Patch to stop confirmation or try to deletion of 0 selected logs

comment:6 Changed 3 years ago by wbowling

Currently if you press the delete key with no logs selected you get a message asking "Are you sure you want to send 0 logs to the Trash?", not the right behavior I think :)

Also, pressing the delete toolbar button with no logs selected will highlight the last log in the list.

Simple patch to fix

Changed 3 years ago by wbowling

Uses == 1 istead of != 0

comment:7 Changed 3 years ago by boredzo

  • Patch Status changed from Accepted to OK; Needs Check-In

Looks good to me. Checking it in.

comment:8 Changed 3 years ago by boredzo

Pushed as bc1492a4a7c7 in adium-1.4 and b9fd746d2a9a in adium.

comment:9 Changed 3 years ago by boredzo

  • Patch Status changed from OK; Needs Check-In to Accepted
Note: See TracTickets for help on using tickets.