Adium

Ticket #12906 (closed defect: fixed)

Opened 7 months ago

Last modified 3 weeks ago

Sent messages do not use the "Text Display" font configured in the Messages Preferences (Snow Leopard)

Reported by: desiato Owned by: Catfish_Man
Milestone: Adium 1.4 Component: Message View
Version: 1.3.6 Severity: normal
Keywords: font fonts message view sent Cc:
Patch Status:

Description

After upgrading to Snow Leopard on my MacBook Pro, I noticed that in an IM session, my sent messages were not showing up in the font I had configured (Monaco 12). Instead they appear to be in the default font (Lucida Grand Regular) but in my configured size (12) versus the default (10).

Received messages are displayed correctly.

I tested this on both AIM and Jabber/Gtalk sessions.

Attachments

adium - chat dialog.tiff (33.6 KB) - added by desiato 7 months ago.
Screenshot of chat session showing problem
adium font config.tiff (111.3 KB) - added by desiato 7 months ago.
Screenshot of adium font configuration
adium - chat dialog - stockholm.tiff (57.1 KB) - added by desiato 7 months ago.
Issue occurring using Stockholm message style
Screen shot 2009-08-29 at 11.43.01 AM.png (28.6 KB) - added by nikegurl637 7 months ago.

Change History

Changed 7 months ago by desiato

Screenshot of chat session showing problem

Changed 7 months ago by desiato

Screenshot of adium font configuration

  Changed 7 months ago by mathuaerknedam

Do you have the same problem when using the Stockholm message style? What version of Adium are you using? And FWIW, the font isn't lucida grande, but either Helvetica or Arial.

  Changed 7 months ago by desiato

Looks like the issue still persists using the Stockholm message style. This is Adium 1.3.6.

Changed 7 months ago by desiato

Issue occurring using Stockholm message style

  Changed 7 months ago by mathuaerknedam

Does it occur if you use 1.4b9?

  Changed 7 months ago by desiato

I don't know; I only used released versions of Adium.

  Changed 7 months ago by nikegurl637

This happened to me too when I updated to 10.6. My typed messages appear in my default font (Arial 10). My sent messages appear in Arial 10. My received messages are my default text display font (Lucida Grande 11). I noticed that my sent messages rendered as my default font, rather than the default text display font. I tested it in many different message styles, and updating adium to 1.4b9 did not fix it either.

Changed 7 months ago by nikegurl637

follow-ups: ↓ 7 ↓ 8   Changed 6 months ago by nsap

nikegurl: I was having the same problem in 1.36 but getting 1.4b9 fixed my issue. If you Ctrl-Click the text field in a message window and choose Font > Show Fonts, choose a new font, and then click the Save as default button, do you still have the same problem?

in reply to: ↑ 6   Changed 6 months ago by bart613

Replying to nsap:

nikegurl: I was having the same problem in 1.36 but getting 1.4b9 fixed my issue. If you Ctrl-Click the text field in a message window and choose Font > Show Fonts, choose a new font, and then click the Save as default button, do you still have the same problem?

This is fixing the problem but just current-conversation-wise. When I open another conversation window, font defaults back to Helvetica. Also - I don't see 'Save as default' button in the Font -> Show Fonts panel.

in reply to: ↑ 6   Changed 6 months ago by mathuaerknedam

Replying to nsap:

If you Ctrl-Click the text field in a message window and choose Font > Show Fonts, choose a new font, and then click the Save as default button, do you still have the same problem?

This won't fix the actual problem, and , depending on what message style is being used, may not even hide it. changing the font in the text entry field will cause the font information you set to be sent to the person with whom you are chatting. If you you aren't trying to send this font info, you shouldn't set the font here.

Replying to bart613:

This is fixing the problem but just current-conversation-wise. When I open another conversation window, font defaults back to Helvetica. Also - I don't see 'Save as default' button in the Font -> Show Fonts panel.

Are you using 1.4b9? Also, try bringing up the font panel using cmd-t rather than a ctrl-click.

  Changed 6 months ago by bart613

Yes, 1.4b9 - and bringing the panel using cmd+t rather using 'Font -> Show Fonts' worked!

Thanks!

  Changed 5 months ago by Zachary West <zacw@…>

  • status changed from new to closed
  • resolution set to fixed

(In  6a8a206aa8af) Address a few font issues that have cropped up recently. Fixes #12906.

In previous releases of Adium, we would drop (in a few situations) the font tag information for outgoing messages if it was Helvetica sized 12. This, of course, was terribly confusing: if you specified any attributes, such as color, weight, decoration, etc., it forced Helvetica again.

In Snow Leopard, Apple started including the background color by default in our attributed strings, which has been causing us to, once again, force font tags in situations where we wouldn't before. Sometimes you'd see Helvetica, sometimes you wouldn't. Confusing.

Instead of trying to send plaintext, which we failed at in a good amount of situations (and all situations in SL), we now always send the font information. This was done by removing the forced Helvetica/12 assumptions in the HTML decoder.

We also respect the "show message fonts" preference for outgoing messages on top of incoming. This was another part of the confusing affects that a non-forced default of Helvetica was causing. Outgoing would appear Helvetica, incoming would be the non-allowed default WKMV font.

I tried to approach this as "strip the background color when foreground isn't specified, go back to the way the old things were" but its behavior was just honestly confusing. Let's be consistent in some way.

  Changed 5 months ago by Zachary West <zacw@…>

(In  d70bc57935ad) Address a few font issues that have cropped up recently. Fixes #12906.

In previous releases of Adium, we would drop (in a few situations) the font tag information for outgoing messages if it was Helvetica sized 12. This, of course, was terribly confusing: if you specified any attributes, such as color, weight, decoration, etc., it forced Helvetica again.

In Snow Leopard, Apple started including the background color by default in our attributed strings, which has been causing us to, once again, force font tags in situations where we wouldn't before. Sometimes you'd see Helvetica, sometimes you wouldn't. Confusing.

Instead of trying to send plaintext, which we failed at in a good amount of situations (and all situations in SL), we now always send the font information. This was done by removing the forced Helvetica/12 assumptions in the HTML decoder.

We also respect the "show message fonts" preference for outgoing messages on top of incoming. This was another part of the confusing affects that a non-forced default of Helvetica was causing. Outgoing would appear Helvetica, incoming would be the non-allowed default WKMV font.

I tried to approach this as "strip the background color when foreground isn't specified, go back to the way the old things were" but its behavior was just honestly confusing. Let's be consistent in some way.

  Changed 5 months ago by zacw

  • milestone set to Adium 1.4

  Changed 5 months ago by zacw

Ticket #12911 has been marked as a duplicate of this ticket.

  Changed 5 months ago by Zachary West <zacw@…>

(In  a81e3542ed8f) Add a "Default font remover" plugin. Refs #12906 (though really fixes it).

This restores our pre-Snow Leopard behavior of sending plaintext when our defualt default font is specified. This also removes the white background Snow Leopard gives us for the attributed string, which would cause it to be sent for every message as well.

The only 'gotcha' here is that, for example, Helvetica-Oblique (italics) is a different actual font than Helvetica. At this point I'm more or less okay with this behavior.

  Changed 5 months ago by Zachary West <zacw@…>

(In  3b3d1d6c5394) Restore back AIHTMLDecoder's assumption that fonts are Helvetica and the sky is blue.

This fixes the "italics" case talked about in adium-1.4/a81e3542ed8f. Refs #12906.

Pre-SL behavior now fully achieved. Hooray.

  Changed 5 months ago by Zachary West <zacw@…>

(In  74a33a2e7467) Add a "Default font remover" plugin. Refs #12906 (though really fixes it).

This restores our pre-Snow Leopard behavior of sending plaintext when our defualt default font is specified. This also removes the white background Snow Leopard gives us for the attributed string, which would cause it to be sent for every message as well.

The only 'gotcha' here is that, for example, Helvetica-Oblique (italics) is a different actual font than Helvetica. At this point I'm more or less okay with this behavior.

  Changed 4 weeks ago by Dimmuxx

Ticket #13746 has been marked as a duplicate of this ticket.

  Changed 3 weeks ago by Robby

Ticket #13776 has been marked as a duplicate of this ticket.

Note: See TracTickets for help on using tickets.