Adium

Ticket #12810 (closed defect: fixed)

Opened 7 months ago

Last modified 4 months ago

Fonts for [NSWebView preferences] are shared across group and regular chats

Reported by: earthmkii Owned by: Catfish_Man
Milestone: Adium 1.4 Component: Message View
Version: 1.4b13 Severity: normal
Keywords: font Cc:
Patch Status:

Description

If I set Regular Chats and Group Chats to the same message style, all options may be unique, but font size is shared.

To reproduce:

  1. Set both Group and Regular Chat message styles to the same style. Variants may be different—it doesn't matter.
  2. Set the Text Display setting for both chats to something unique (ex: Helvetica 10 and Times 36).
  3. Open both a group chat and regular chat window.
  4. In the Messages pref pane, watch and enjoy the font styles for both windows toggle as you switch between the Group and Regular tabs.

Change History

Changed 5 months ago by jas8522

  • version changed from 1.4hg to 1.4b13
  • milestone set to Adium 1.4

Yes indeed.

Changed 4 months ago by zacw

  • summary changed from If Group and Regular chats use the same message view, they must share the same font style to Fonts for [NSWebView preferences] are shared across group and regular chats

The way the fonts are set, this is done intentionally (more or less) because the fonts were intended to update to all windows as it was happening.

One way might be to share the preference instances between group chats and regular chats separately, by setting the preference identifier.

Changed 4 months ago by Evan Schoenberg

  • status changed from new to closed
  • resolution set to fixed

(In  9232899b7ef5) For our WebViews, use a preferences identifier of activeStyle-preferenceGroup. This uniques group chats from one-on-one chats when their preferences are being stored separately. The WebView preference identifier is used only transiently in our usage to allow all WebViews to update when one changes (via the preferences); this doesn't change our actual storage and retrieval of the prefs. Fixes #12810 by implementing Zac's suggestion there.

Note: See TracTickets for help on using tickets.