%serviceIcon% fails to display IRC service icon

[mathuaerknedam]

Using the patch in #12664, I can see the service icons for each of my accounts except IRC. It seems to work fine for yahoo, jabber, google, and aim.

[mathuaerknedam]

This is what Adium is trying to load for IRC:

/Users/mneedham/src/Adium/build/Release-Debug/Adium.app/Contents/Resources/Service Icons/Aqua.AdiumServiceIcons

It's not specifying what icon to load. For yahoo it loads /Users/mneedham/src/Adium/build/Release-Debug/Adium.app/Contents/Resources/Service Icons/Aqua.AdiumServiceIcons/yahoo.png.

I did find and IRC icon at /Users/mneedham/src/adium/Plugins/Purple\ Service/irc.png. I copies that into the Aqua.AdiumServiceIcons bundle, but that didn't help. I poked around the source, but I can't figure out why the IRC serviceicon isn't getting a complete path specified in the header.

[mathuaerknedam]

While I was looking at the IRC icon in the purple plugin, I noticed that it was slightly undersized (40px) compared to the other icons (48px), and that it was missing a small version (16px). I'm attaching a 48px version that's been slightly cleaned up and a 16px version.

[mathuaerknedam]

48px irc service icon

[mathuaerknedam]

16px irc service icon

[zacw]

The larger IRC icon looks weird. I think I am just going to steal Pidgin's current IRC icon, it's nicer.

[Zachary West <zacw@…>]

(In  38d242c5c33e) When loading a service icon from service ID and the pack doesn't specify one, ask the first service with that ID for it.

This also will return 'nil' instead of a dead path for service icons which are not supported by an icon pack, but which a service specifies as a default. Refs #12697. (We don't know the paths of default service icons, yet)

[Zachary West <zacw@…>]

(In  4e544bf1b994) Add -[AIService pathForDefaultServiceIconOfType:], and use it for replacing %serviceIconImg% in headers. Fixes #12697.

[Zachary West <zacw@…>]

(In  545ce4868ddd) When loading a service icon from service ID and the pack doesn't specify one, ask the first service with that ID for it.

This also will return 'nil' instead of a dead path for service icons which are not supported by an icon pack, but which a service specifies as a default. Refs #12697. (We don't know the paths of default service icons, yet)

[Zachary West <zacw@…>]

(In  df2c24e3844c) Add -[AIService pathForDefaultServiceIconOfType:], and use it for replacing %serviceIconImg% in headers. Fixes #12697.

[Zachary West <zacw@…>]

(In  253da42ff00e) Add a small IRC icon and an improved larger one. Refs #12697.

[Zachary West <zacw@…>]

(In  ecb36859abb9) Add a small IRC icon and an improved larger one. Refs #12697.