outgoing icon in header missing in chats opened on launch

[mathuaerknedam]

I'm not sure how long this has been around, probably forever, but it takes a specific combination of factors to replicate.

1) Use a message style that includes the outgoing icon (most only include the incoming icon). Smooth Operator ☿ or Ninja will demonstrate this.

2) Enable "Save opened chats when quitting".

3) Don't have accounts connect on launch.

Under these circumstances, the chat window will open with a header displaying the incoming icon and a missing image placheolder for the outgoing icon. If you then connect your accounts the icon will not appear (because the header is never updated) but the icon will appear if you close and reopen the chat.

I've checked in the webkit element inspector, and verified that Adium is referencing an image that does not exist.

[evands]

The account actually gets its icon set and then reset. -[AIWebkitMessageViewStyle fillKeywordsForBaseTemplate:chat:]: uses the first icon path; however, that first icon is deleted and the second one is set. This would all be fine, but the header icons don't update properly...

[evands]

The icons can't be updated because the webview's documentFrame doesn't exist yet.

[Evan Schoenberg]

(In  9f11b96baf1d) If we try to update icons while the webview doesn't have an accessible documentFrame (e.g. while it is still working on loading its initial HTML), try again after a second. This fixes icons which are part of the initial bolus of information presented by a webview that change shortly after it loads, which can most noticeably happen when restoring a chat using a webview with icons in its header but could also occur if a user icon changed as we opened a chat window.

Fixes #12696