Adium

Ticket #12666 (closed enhancement: fixed)

Opened 8 months ago

Last modified 5 months ago

please enable %sendercolor% in header.html

Reported by: mathuaerknedam Owned by: earthmkii
Milestone: Adium 1.4 Component: Message View
Version: 1.4hg Severity: normal
Keywords: SO3 Cc:
Patch Status:

Description

I'd like to be able to use %sendercolor% in header.html. I'll try to make a patch.

Change History

Changed 8 months ago by mathuaerknedam

I'm failing at the patch. I'd appreciate it if someone else could make this work or point me in the right direction.

Changed 7 months ago by mathuaerknedam

  • owner changed from Catfish_Man to earthmkii

Changed 7 months ago by mathuaerknedam

  • type changed from defect to enhancement
  • milestone set to Adium 1.4

Changed 5 months ago by Zachary West <zacw@…>

  • status changed from new to closed
  • resolution set to fixed

(In  a4f812b97eff) Add %senderColor% to the header keywords. Fixes #12666.

Changed 5 months ago by Zachary West <zacw@…>

(In  7e41d8e52be8) Add %senderColor% to the header keywords. Fixes #12666.

Changed 5 months ago by mathuaerknedam

I totally should have anticipated this, but a simple %senderColor% won't quite work, at least not the way I"ve planned to use it in SO3. Specifically, %senderColor% resolves only for the incoming user. I also need the outgoing sendercolor. Based on precedent set by the icon path keywords, I'd suggest that the header use %incomingColor% and %outgoingColor%.

Sorry to have not noticed this in advance, I hope this wasn't a big waste of time.

Changed 5 months ago by mathuaerknedam

  • status changed from closed to new
  • resolution fixed deleted

Reopening so that it's more clear (shows in reports) that the fix isn't actually useful for the intended purpose (because of a bad request...).

Changed 5 months ago by Zachary West <zacw@…>

  • status changed from new to closed
  • resolution set to fixed

(In  ad119ec778fc) Add %incomingColor% and %outgoingColor%, remove %senderColor% in headers. Fixes #12666.

This also should speed up significantly message display for styles that don't specify a custom set of colors, since we won't be querying the file for every message any longer.

Changed 5 months ago by Zachary West <zacw@…>

(In  e0421b510067) Add %incomingColor% and %outgoingColor%, remove %senderColor% in headers. Fixes #12666.

This also should speed up significantly message display for styles that don't specify a custom set of colors, since we won't be querying the file for every message any longer.

Note: See TracTickets for help on using tickets.