Adium

Ticket #12664 (closed patch: fixed)

Opened 8 months ago

Last modified 8 months ago

%serviceIconImg% is buggy

Reported by: mathuaerknedam Owned by: Catfish_Man
Milestone: Adium 1.4 Component: Message View
Version: 1.4hg Severity: normal
Keywords: SO3 Cc:
Patch Status: Accepted

Description

%serviceIconImg% (added by David in svn 23506) is borked. It displays as a missing icon, but clicking it reveals alt text that is a valid path to the correct service icon. The img src="@". I imagine the alt text should be simply the name of the service. I'll try to make a patch.

Attachments

serviceIconImg.diff (1.1 KB) - added by mathuaerknedam 8 months ago.
there was a "%" missing
newserviceicon.diff (1.2 KB) - added by mathuaerknedam 8 months ago.
new patch, this one also adds a tooltip to the icon that names the service

Change History

Changed 8 months ago by mathuaerknedam

there was a "%" missing

Changed 8 months ago by mathuaerknedam

  • patch_status set to Needs Dev Review
  • type changed from defect to patch
  • milestone set to Adium 1.4

Changed 8 months ago by mathuaerknedam

new patch, this one also adds a tooltip to the icon that names the service

Changed 8 months ago by mathuaerknedam

I just added a second patch. This new one includes the first, but also adds the service name as a tooltip to the service icon.

Changed 8 months ago by Evan Schoenberg

  • status changed from new to closed
  • resolution set to fixed

(In  879cd64c4004) Patch from mathuaerknedam to fix %serviceIconImg% and add a tooltip to it. Fixes #12664. Thanks!

Changed 8 months ago by Robby

  • patch_status changed from Needs Dev Review to Accepted
Note: See TracTickets for help on using tickets.