Adium/Libpurple sends status auto-replies on IRC in response to CTCP messages

[boredzo]

Steps to Reproduce

1. Set a status with auto-reply turned on.
2. From another client (or telnet), send yourself a CTCP request, such as CTCP VERSION.

Expected behavior

Adium sends its CTCP response (if it has one for that CTCP message).

Actual behavior

Adium sends its CTCP response, then a status auto-reply via NOTICE.

Notes

This is Adium sending the auto-reply as a NOTICE; I'm not talking about the 301 code that the server itself sends on behalf of Adium (which Adium has nothing to do with).

You can reproduce this with CTCP responses as well as requests if you include one or more additional words after the CTCP name. For example, “VERSION foo”.

Adium does not send the auto-reply when the message is not a CTCP. It's possible that Adium is performing a test the wrong way around.

Everywhere you see “Adium” in this ticket, read “Adium or Libpurple”.

Originally reported by nyso and satmd on #adium.

[boredzo]

Found STR for doing it with CTCP responses (further thanks to satmd).

[zacw]

libpurple doesn't send autoresponses unless it's a server-supported message type. The (Autoreply) prefix makes me have no doubt it's an Adium thing.

[Robby]

Still there in b13?

[zacw]

I'm confident it is, since this code did not change.

[Zachary West <zacw@…>]

(In  884572c52b7d) Never send an autoreply to an IRC message. The server does this for us. Fixes #12621.

[Zachary West <zacw@…>]

(In  5784d39a3ed5) Never send an autoreply to an IRC message. The server does this for us. Fixes #12621.