Adium

Ticket #12359 (closed defect: fixed)

Opened 9 months ago

Last modified 5 months ago

Spell checking fails back to default system language (again).

Reported by: ftpd Owned by:
Milestone: Adium 1.4 Component: Adium UI
Version: 1.4b6 Severity: regression
Keywords: Cc:
Patch Status:

Description

Hi, I'm using 1.4b6 on Mac OS X 10.5.7. As some time ago, I'm now experiencing problem with remembering of my spellchecker preferences. I'm using CocoAspell and it works fine in other applications, problem seems to appear just in Adium (I'm using Safari to write that post and in it's settings I can my language selection I've set, but when changing focus to Adium, it still tells me, that checked language is English).

Problem is full reproductible, I've done little research and all my colleagues who are using Adium are experiencing this issue.

Thanks in advance,

Bartek 'ftpd' Stalewski

Change History

Changed 9 months ago by berdan

  • owner berdan deleted
  • component changed from Localization to Adium UI

Changed 9 months ago by niccarter

I'd like to confirm this as also happening for me, v1.4b6 OS X 10.5.7 As a test, I wrote some (Australian spelling) words into TextEdit and it accepted them as having the correct spelling, typed in the American English equivalents and it gave me the red squiggly line (aka, wrong spelling). Typed those into an Adium chat window and it said the Australian spelling versions were incorrect and the American versions were correct.

Note: I don't know when this started happening, as I normally just ignore the grammar and spelling suggestions in Adium, but it finally bugged me enough to sign up for the tracker... :)

Changed 7 months ago by Robby

Ticket #12601 has been marked as a duplicate of this ticket.

Changed 7 months ago by Robby

  • severity changed from normal to regression
  • milestone set to Adium 1.4

Are you able to remember whether this already happened with 1.3.x?

Changed 7 months ago by ftpd

I'm _sure_ this already happened, and I'm _almost_ sure it was with 1.3.x (for sure before 1.4, but maybe in 1.2.x line?). There was a build (or a few, like 2-3, builds) with this issue, but then I haven't created any ticket or sth, just waited and in one build problem was solved.

Changed 7 months ago by Robby

Yeah, #10752 was meant to fix this. Hm...

Changed 7 months ago by ftpd

Yeah, it _was_ fixed, but now (since 3 builds, afair) it's broken again.

Changed 5 months ago by evands

Have you set the spelling preference in Adium previously? Adium tracks this separately, to allow per-contact spelling preferences, so changing your language can result in a seeming loss of synchronization even though Adium is, in general, doing the right thing.

Changed 5 months ago by ftpd

Nope, I've never touched spelling preferences in Adium. I've used Leopard with CocoAspell at first and now I have Snow Leopard with polish spellchecking included, so I've set it system-wide in System Preferences. It works in any application beside Adium.

Changed 5 months ago by zacw

  • status changed from new to pending

Edit > Spelling > Show Spelling and Grammar for your contacts.

What language is selected for the user that the language isn't working for?

What is your global preference?

It's likely that the CocoAspell operated by setting the spelling and grammar for every window of yours that it opened to the particular one. This would cause Adium to save that spelling preference for the users in question. Changing it to Polish for your contacts should fix it.

Changed 5 months ago by zacw

  • status changed from pending to new

Actually, I can reproduce some annoying problems, but I don't see why; I can follow the code and it's setting the language as expected but the spell check doesn't update.

Changed 5 months ago by Zachary West <zacw@…>

  • status changed from new to closed
  • resolution set to fixed

(In  4f51d10a2af5) Clean up the per-contact spelling a little. I think this fixes #12359.

This uses new, proper "language-grabbing" methods from the spell checker, as well as properly saves the spelling if the spelling was changed and the window was immediately closed. In this case, it would end up saving the wrong value.

Changed 5 months ago by Zachary West <zacw@…>

(In  6a41be7632e5) Clean up the per-contact spelling a little. I think this fixes #12359.

This uses new, proper "language-grabbing" methods from the spell checker, as well as properly saves the spelling if the spelling was changed and the window was immediately closed. In this case, it would end up saving the wrong value.

Note: See TracTickets for help on using tickets.