Adium

Ticket #11898 (closed patch: fixed)

Opened 11 months ago

Last modified 7 months ago

"140" character indicator in timeline window truncates to "14"

Reported by: neilio Owned by: zacw
Milestone: Adium 1.4 Component: Service/Twitter
Version: 1.4hg Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description

If you resize the timeline window, the # of characters remaining in the entry field gets cut off and displays only "14" instead.

 http://img.skitch.com/20090411-tkfnmjj1bs3xdtey9r72fafp23.png

Attachments

sholt_11898.diff (1.2 KB) - added by earthmkii 7 months ago.
sholt_11898_2.diff (1.3 KB) - added by earthmkii 7 months ago.
New patch with doesn't revert #11996

Change History

Changed 11 months ago by jas8522

  • pending changed from 0 to 1
  • milestone set to Needs feedback from users

Someone else mentioned this once on IRC, but neither Zac nor myself could reproduce it (unless Zac has since). There must be some specific circumstance that causes this to happen sometimes and not others - until we figure that out, this will likely not be fixed!

Any idea what those exact steps to reproduce could be?

Changed 11 months ago by trac-robot

  • status changed from new to closed
  • pending changed from 1 to 0

This ticket was closed automatically by the system. It was previously set to a Pending status and hasn't been updated within 14 days.

Changed 7 months ago by earthmkii

Changed 7 months ago by earthmkii

  • status changed from closed to new
  • patch_status set to Needs Dev Review
  • type changed from defect to patch
  • milestone changed from Needs feedback from users to Adium 1.4

I've been able to reproduce this. The NSView was expanding/contacting with the window.

Since we resize the counter view when the character count is updated, we shouldn't need to have this auto resize ever.

Patch attached.

Changed 7 months ago by earthmkii

New patch with doesn't revert #11996

Changed 7 months ago by earthmkii

Old patch undoes #11996. We don't want that.

New one resets the NSView size to the string's size when the view bounds are changed.

...There has to be a better way of doing this.

Changed 7 months ago by Stephen Holt <sholt@…>

  • status changed from new to closed
  • resolution set to fixed

(In  adafeb783ff9) Correct the tendancy of the character counter to shift positions/shrink when the message window is resized. Fixes #11898.

Changed 7 months ago by Stephen Holt <sholt@…>

(In  4c8b116ca530) Correct the tendancy of the character counter to shift positions/shrink when the message window is resized. Fixes #11898.

Changed 7 months ago by Robby

  • patch_status changed from Needs Dev Review to Accepted

Changed 7 months ago by Stephen Holt <sholt@…>

(In  4c8b116ca530) Correct the tendancy of the character counter to shift positions/shrink when the message window is resized. Fixes #11898.

Note: See TracTickets for help on using tickets.