%keywords% and html tempate agnosticism

[mathuaerknedam]

It would be nice if the various message style %keywords% worked regardless of the HTML template in which they are located. While the keywords were (I think) originally intended to be used to display the inserted content to users, they're now seen a much expanded role in styling. New keywords are being added for the express purpose of allowing greater control of styling (especially %status% and %mesageClasses%).

For example, I'd like to include %service% in status.html so that I can provide styling specific to status/event messages in IRC.

Also, the usefulness of the HTML template fallback is limited by the inability of some templates to process some keywords.

[zacw]

(In [26911]) Add %service% to all WKMV templates. Fixes #11872. We use the chat's account's service instead of the source's because it is likely for statuses that the source does not exist. I don't see any other keywords which could potentially be used between status and message; the remaining are all rather specific to the type of content (sender, mostly, really). Fixes #11872.

[mathuaerknedam]

My original post was unclear, but the patch I attached implement what I was thinking of. Specifically, when a %keyword% doesn't "make sense" (like %status% in an outgoing message) it replaces it with "" rather than ignoring it. Structurally, there's little reason for most message styles to have different html templates for status and message content, and a single root-level content.html will suffice. The place where I've seen this break down is the keywords, but this is easily solved with this patch.

There are other keywords that could be treated in the same way, but these are the ones I care about right now. If the patch is accepted I'll happily add the other keywords.

[mathuaerknedam]

Hm, There's something wrong with the patch. %status% is getting replaced with "" in status messages too. I'm looking into it.

[mathuaerknedam]

Patch fixed, old one deleted.

[mathuaerknedam]

I'm going to attach a series of pics that demonstrate what happens now and what happens after the patch.

[mathuaerknedam]

Status tooltip, pre-patch

[mathuaerknedam]

Status tooltip, post-patch

[mathuaerknedam]

Message tooltip, pre-patch

[mathuaerknedam]

Message tooltip, post-patch

[Zachary West <zacw@…>]

(In  1b8a3dce56d1) Patch from mathuaerknedam to replace status keywords in messages with blanks, and vice versa. Fixes #11872.

[Zachary West <zacw@…>]

(In  0cd78c81e7bd) Patch from mathuaerknedam to replace status keywords in messages with blanks, and vice versa. Fixes #11872.