Adium

Ticket #11799 (closed crash: fixed)

Opened 12 months ago

Last modified 4 months ago

Crash in Bonjour thread

Reported by: endorphinity Owned by: nobody
Milestone: Adium 1.4 Component: Service/Bonjour
Version: 1.3.3 Severity: major
Keywords: Cc:
Patch Status:

Description

Adium crashed when I tried to type in the newly opened tab (Bonjour, if that matters). Crash log is attached.

Attachments

Adium_2009-03-20-172505_jMacBook.crash (42.0 KB) - added by endorphinity 12 months ago.
Crash log

Change History

Changed 12 months ago by endorphinity

Crash log

Changed 11 months ago by jas8522

  • severity changed from normal to major
  • component changed from Adium Core to Bonjour
  • summary changed from Crash on typing to Crash in Bonjour thread
  • priority changed from normal to highest
  • milestone set to Adium 1.3.x
  • type changed from defect to crash

I have also been seeing similar crashes randomly from the Bonjour thread. Will keep debug logging enabled to see if I can come up with something good.

Changed 7 months ago by Robby

  • milestone changed from Adium 1.4.x to Adium 1.3.6

Changed 7 months ago by Robby

  • milestone changed from Adium 1.3.6 to Adium 1.3.7

1.3.6 has been released.

Changed 5 months ago by Robby

  • milestone changed from Adium 1.3.7 to Adium 1.3.8

Changed 4 months ago by Evan Schoenberg

  • status changed from new to closed
  • resolution set to fixed

(In  fa28661f40dd) Prevent attempting to set a nil property on an AWEzvXMLNode. This turns a crash into a warning.

One such case could occur, and seems to have at least once for one user in #11799, if AWEzvContactManager's myInstanceName is nil. This needs further investigation.

Fixes #11799

Changed 4 months ago by Evan Schoenberg

(In  da02036bbb7a) Prevent attempting to set a nil property on an AWEzvXMLNode. This turns a crash into a warning.

One such case could occur, and seems to have at least once for one user in #11799, if AWEzvContactManager's myInstanceName is nil. This needs further investigation.

Fixes #11799

Changed 4 months ago by Evan Schoenberg

(In  c770142607e4) If Bonjour disconnects but the user opens a contact window in the moment before the contact disappears from the list, it wass possible to attempt to open with a nil avInstanceName. Furthermore, if Bonjour disconnects, attempting to send a message to a still-open Bonjour chat could try to reference avInstanceName which would previously be nil after disconnect.

There's no reason to be so aggressive with having avInstanceName only be set while logged in; it's a single string, and it doesn't generally change. We'll create it in init and destroy it in dealloc for AWEzvContactManager.

Fixes #11799 fully.

Changed 4 months ago by Evan Schoenberg

(In  13898cc883cd) If Bonjour disconnects but the user opens a contact window in the moment before the contact disappears from the list, it wass possible to attempt to open with a nil avInstanceName. Furthermore, if Bonjour disconnects, attempting to send a message to a still-open Bonjour chat could try to reference avInstanceName which would previously be nil after disconnect.

There's no reason to be so aggressive with having avInstanceName only be set while logged in; it's a single string, and it doesn't generally change. We'll create it in init and destroy it in dealloc for AWEzvContactManager.

Fixes #11799 fully.

Changed 4 months ago by Robby

  • milestone changed from Adium 1.3.8 to Adium 1.4
Note: See TracTickets for help on using tickets.