Adium

Ticket #11588 (closed defect: fixed)

Opened 14 months ago

Last modified 5 months ago

connection/disconnection messages have inconsistent %messageClasses%

Reported by: mathuaerknedam Owned by: earthmkii
Milestone: Adium 1.4 Component: Message View
Version: 1.3 Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description (last modified by mathuaerknedam) (diff)

formerly described in #10189.

  • When my buddy connects (to yahoo) %messageClasses% = "status online".
  • When my buddy disconnects (from yahoo) %messageClasses% = "status offline".
  • When I connect (to yahoo) %messageClasses% = "outgoing status connected".
  • When I disconnect (from yahoo) %messageClasses% = "outgoing status disconnected".

I get the same results with xmpp and IRC.

Besides the inconsistent online/offline vs connected/disconnected classing, I think that the "outgoing" on my messages should not be there, at least until we start classing *all* status messages as either incoming or outgoing (which we may never do).

Attachments

de-outEvents.diff (0.8 KB) - added by mathuaerknedam 9 months ago.
Patch to remove "outgoing" class from events

Change History

Changed 14 months ago by mathuaerknedam

  • description modified (diff)
  • milestone set to Adium 1.3.x

Changed 14 months ago by mathuaerknedam

  • description modified (diff)

Changed 9 months ago by mathuaerknedam

Patch to remove "outgoing" class from events

Changed 9 months ago by mathuaerknedam

  • patch_status set to Needs Dev Review

I've added a patch that resolves part of the issue mentioned here, the presence of "outgoing" on the local user's connected/disconnected messages. This is an extension of David's changeset [23296], which already removed "status" and "incoming" from events. The issue of online/offline vs connected/disconnected remains.

Changed 8 months ago by Robby

  • milestone changed from Adium 1.4.x to Adium 1.4

Changed 7 months ago by mathuaerknedam

  • owner set to earthmkii

Changed 5 months ago by Zachary West <zacw@…>

  • status changed from new to closed
  • resolution set to fixed

(In  29c166695832) Patch from mathuaerknedam to remove outgoing (on top of incoming) for AIContentEvents. Fixes #11588.

Changed 5 months ago by Robby

  • patch_status changed from Needs Dev Review to Accepted

Changed 5 months ago by Zachary West <zacw@…>

(In  1b04b22253d4) Patch from mathuaerknedam to remove outgoing (on top of incoming) for AIContentEvents. Fixes #11588.

Note: See TracTickets for help on using tickets.